Inconsistent use of btn-danger

Bug #1792778 reported by Corey Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Vishal Manchanda

Bug Description

I think this started in queens as a result of: https://review.openstack.org/#/c/339278/

This changed some delete confirmation buttons from btn-primary to btn-danger. However, some buttons, such as "Delete Image", still uses btn-primary. This results in inconsistent colors for destructive buttons on confirmation modals.

summary: - Inconsistent use of dangerous buttons
+ Inconsistent use of btn-danger
description: updated
Ivan Kolodyazhny (e0ne)
tags: added: ux
Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
tags: added: low-hanging-fruit
Changed in horizon:
assignee: nobody → Vishal Manchanda (vishalmanchanda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/618096

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/618096
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=55835c7305b52f03f8d391f5715ff8d3b75177d2
Submitter: Zuul
Branch: master

commit 55835c7305b52f03f8d391f5715ff8d3b75177d2
Author: manchandavishal <email address hidden>
Date: Thu Nov 15 07:45:56 2018 +0000

    Fix: Inconsistent use of btn-danger

    The color of delete image button is inconsistent with other
    destructive buttons.
    This patch fixes the issue.

    Change-Id: Id7acd54e5535912eff4e69cbfd360ef02e7d8786
    Closes-Bug: #1792778

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 15.0.0.0b2

This issue was fixed in the openstack/horizon 15.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.