Basket Actions: Check / Clear all box doesn't remove items from the basket

Bug #1792371 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Eg 3.2 beta

If you check the box at the top of a list of results to select the entire page that works as expected and you will have 10 (or however many) records in your basket. If you click it again though to clear the screen the boxes will be un-checked, but the number of records in the basket will still be 10. Clicking it again increases the count to 20, and so on. It's a simple fix, branch is on the way.

Revision history for this message
Jason Boyer (jboyer) wrote :

Right about here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1792371_clear_selection working/user/jboyer/lp1792371_clear_selection

To test:
Pre-patch, perform a search, click the checkbox above the list of results to select and add all records on the page to your basket. The number of items in your basket should be 10. Click it again to clear all of the checkboxes, the number of items in your basket is still 10.

Apply patch and repeat steps above, notice that now the 10 items in your basket are removed when you clear the whole-page checkbox.

description: updated
Jason Boyer (jboyer)
tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Works like a charm!

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

tags: added: opac signedoff
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Kathy Lussier (klussier) wrote :

Works for me too! I added Terran's signoff and my own and merged the changes to master for inclusion in the upcoming 3.2 RC. Thanks Jason and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: none → 3.2-rc
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.