[CI] New image prepare workflow is incompatible with updates and upgrades

[Jiří Stránský]

To reuse the ContainerImagePrepare way of preparing containers for update/upgrade, we'd have to amend things a little.

Main issue is probably that we do not (and cannot) run any external_*_tasks during normal `update run` and `upgrade run` commands, because those commands are sometimes run multiple times for granularity (e.g. even per-node). And external_*_tasks are used to run things like ceph-ansible, so we don't want to reexeute such things on each per-node update/upgrade call.

This is also why the current proposed fixes for update job don't make the job green yet.

[Jiří Stránský (jistr)]

We should probably try:

1) Plug in whatever generates correct Heat image parameters to the updates+upgrades workflows

2) Use external update/upgrade commands to run the image uploading? Initially it seemed a bit weird but more i think about it, the more it feels ok, and at least we'd be using the same thing under the hood that we're using during deploy.

I'll look into this more next week and gather some feedback on this idea.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/601231

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/601430

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jiri Stransky (<email address hidden>) on branch: master
Review: https://review.openstack.org/601231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/601430
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=93ebf8962cbe044c6ec716d549b86e92a3d0ce5f
Submitter: Zuul
Branch: master

commit 93ebf8962cbe044c6ec716d549b86e92a3d0ce5f
Author: Steve Baker <email address hidden>
Date: Mon Sep 10 15:27:01 2018 -0600

    Run prepare during package_update workflow

    Image prepare is not currently running during the updates workflow,
    which is breaking the updates CI job.

    Depends-On: I9bd21b67a9bf9254458351e8ba784ed66f9949f4
    Change-Id: I26ed63c8e8428b05af20ee68ca6a2b089b3d8bc7
    Partial-Bug: #1791332

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/609718

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/609718
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=67bab1682ea5d210c30868236908094cb19cbc36
Submitter: Zuul
Branch: stable/rocky

commit 67bab1682ea5d210c30868236908094cb19cbc36
Author: Steve Baker <email address hidden>
Date: Mon Sep 10 15:27:01 2018 -0600

    Run prepare during package_update workflow

    Image prepare is not currently running during the updates workflow,
    which is breaking the updates CI job.

    Depends-On: I9bd21b67a9bf9254458351e8ba784ed66f9949f4
    Change-Id: I26ed63c8e8428b05af20ee68ca6a2b089b3d8bc7
    Partial-Bug: #1791332
    (cherry picked from commit 93ebf8962cbe044c6ec716d549b86e92a3d0ce5f)