Deploying overcloud fails if there's a plan

[Juan Antonio Osorio Robles]

Trying so ends up in the following error:

Starting new HTTPS connection (1): 192.168.24.2
https://192.168.24.2:13808 "GET /v1/AUTH_1b8b17ad40844459bfed6649858ce2ce/overcloud/plan-environment.yaml HTTP/1.1" 200 22917
Removing the current plan files
'module' object has no attribute 'empty_container'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 402, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/command.py", line 25, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 184, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 877, in take_action
    self._deploy_tripleo_heat_templates_tmpdir(stack, parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 360, in _deploy_tripleo_heat_templates_tmpdir
    new_tht_root, tht_root)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 385, in _deploy_tripleo_heat_templates
    type(self)._keep_env_on_update)
  File "/usr/lib/python2.7/site-packages/tripleoclient/workflows/plan_management.py", line 207, in update_plan_from_templates
    swiftutils.empty_container(swift_client, name)
AttributeError: 'module' object has no attribute 'empty_container'
clean_up DeployOvercloud: 'module' object has no attribute 'empty_container'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/600467

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600467
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a63963964c65cb061e90e51801be901ec4068391
Submitter: Zuul
Branch: master

commit a63963964c65cb061e90e51801be901ec4068391
Author: Brad P. Crochet <email address hidden>
Date: Thu Sep 6 11:35:50 2018 -0400

    Reintroduce empty_container for tripleoclient

    TripleoClient still uses empty_container. Put it back until we can
    rework the tripleoclient code.

    Change-Id: I96109c2452d7568da4a9374661a8ba8b9ba71458
    Closes-Bug: #1791120

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/601310

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/601427

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/601428

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/601310
Reason: https://review.openstack.org/#/c/601428/ should be done, there's other problems

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/601427
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=af108b8d553b7e7c8e3ba40c9bd2928656322680
Submitter: Zuul
Branch: master

commit af108b8d553b7e7c8e3ba40c9bd2928656322680
Author: Alex Schultz <email address hidden>
Date: Mon Sep 10 21:06:20 2018 +0000

    Revert "Reintroduce empty_container for tripleoclient"

    This reverts commit a63963964c65cb061e90e51801be901ec4068391.

    Change-Id: I5087f9438dc78e7225e82bdafb6941c6aa7ea29c
    Related-Bug: #1791120

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/601428
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b02e32964b17a7fb76dbe45be57346c52f5e4e59
Submitter: Zuul
Branch: master

commit b02e32964b17a7fb76dbe45be57346c52f5e4e59
Author: Alex Schultz <email address hidden>
Date: Mon Sep 10 21:06:35 2018 +0000

    Revert "Use swift bulk-delete when deleting a plan"

    This reverts commit f6891826c9ccaaca0614239d1f162a3f66a43162.

    Change-Id: I8de39d5f9ce4c64fa3327ca45a7abcbe774852c0
    Closes-Bug: #1791120

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.0.0 release.