syntax error in manager.py ping_ip_address

[Ryan Beisner]

The following commit introduced a syntax error, causing the module install and run time errors for nova-lxd Rocky.

https://github.com/openstack/nova-lxd/commit/84a7945bca43205ce2c92cdd34b27da12749d24f

/nova_lxd_tempest_plugin/tests/scenario/manager.py

A review is underway to resolve the issue, which will then be tagged for release and/or backport as appropriate:

https://review.openstack.org/#/c/599351

[Ryan Beisner (1chb1n)]

2018-09-05 20:16:31 DEBUG install Reading package lists...
2018-09-05 20:16:31 DEBUG install Building dependency tree...
2018-09-05 20:16:31 DEBUG install Reading state information...
2018-09-05 20:16:31 DEBUG install genisoimage is already the newest version (9:1.1.11-3ubuntu2).
2018-09-05 20:16:31 DEBUG install python-six is already the newest version (1.11.0-2).
2018-09-05 20:16:31 DEBUG install xfsprogs is already the newest version (4.9.0+nmu1ubuntu2).
2018-09-05 20:16:31 DEBUG install librbd1 is already the newest version (13.2.1+dfsg1-0ubuntu2~cloud0).
2018-09-05 20:16:31 DEBUG install nova-compute is already the newest version (2:18.0.0-0ubuntu3~cloud0).
2018-09-05 20:16:31 DEBUG install nova-compute-lxd is already the newest version (18.0.0~rc1-0ubuntu1~cloud0).
2018-09-05 20:16:31 DEBUG install python-psutil is already the newest version (5.4.6-1build1~cloud0).
2018-09-05 20:16:31 DEBUG install The following package was automatically installed and is no longer required:
2018-09-05 20:16:31 DEBUG install grub-pc-bin
2018-09-05 20:16:31 DEBUG install Use 'apt autoremove' to remove it.
2018-09-05 20:16:31 DEBUG install 0 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.
2018-09-05 20:16:31 DEBUG install 3 not fully installed or removed.
2018-09-05 20:16:31 DEBUG install After this operation, 0 B of additional disk space will be used.
2018-09-05 20:16:31 DEBUG install Setting up python-nova-lxd (18.0.0~rc1-0ubuntu1~cloud0) ...
2018-09-05 20:16:32 DEBUG install File "/usr/lib/python2.7/dist-packages/nova_lxd_tempest_plugin/tests/scenario/manager.py", line 569
2018-09-05 20:16:32 DEBUG install result = test_utils.call_until_true(ping, timeout, 1)
2018-09-05 20:16:32 DEBUG install ^
2018-09-05 20:16:32 DEBUG install SyntaxError: invalid syntax
2018-09-05 20:16:32 DEBUG install
2018-09-05 20:16:32 DEBUG install dpkg: error processing package python-nova-lxd (--configure):
2018-09-05 20:16:32 DEBUG install installed python-nova-lxd package post-installation script subprocess returned error exit status 101
2018-09-05 20:16:32 DEBUG install dpkg: dependency problems prevent configuration of nova-compute-lxd:
2018-09-05 20:16:32 DEBUG install nova-compute-lxd depends on python-nova-lxd (= 18.0.0~rc1-0ubuntu1~cloud0) | python3-nova-lxd (= 18.0.0~rc1-0ubuntu1~cloud0); however:
2018-09-05 20:16:32 DEBUG install Package python-nova-lxd is not configured yet.
2018-09-05 20:16:32 DEBUG install Package python3-nova-lxd is not installed.
2018-09-05 20:16:32 DEBUG install
2018-09-05 20:16:32 DEBUG install dpkg: error processing package nova-compute-lxd (--configure):
2018-09-05 20:16:32 DEBUG install dependency problems - leaving unconfigured
2018-09-05 20:16:32 DEBUG install No apport report written because the error message indicates its a followup error from a previous failure.
2018-09-05 20:16:32 DEBUG install dpkg: dependency problems prevent configuration of nova-compute:
2018-09-05 20:16:32 DEBUG install nova-compute depends on nova-compute-kvm | nova-compute-hypervisor; however:
2018-09-05 20:16:32 DEBUG install Package nova-compute-kvm is not installed.
2018-09-05 20:16:32 DEBUG install Package nova-compu...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/599351
Committed: https://git.openstack.org/cgit/openstack/nova-lxd/commit/?id=c4c16bcf497ef77119509f6ab63a3b769e41e9be
Submitter: Zuul
Branch: master

commit c4c16bcf497ef77119509f6ab63a3b769e41e9be
Author: Alex Kavanagh <email address hidden>
Date: Mon Sep 3 11:33:57 2018 +0100

    Fix bug in scenario/manager and cover it with pep8

    manager.py had a syntax error which caused the module to be not
    installable. This wasn't picked up in testing. This fixes the bug
    and adds pep8 coverage to the nova_lxd_tempest_plugin so that the module
    always remains installable.

    Also, this fixes the tempest concurrency at 1. See the related bugs.

    Closes-bug: #1790956
    Related-Bug: #1790943
    Change-Id: Ie542b062a9f0997f6363877ff03f0f9bfc8f3d43

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/600391

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600391
Committed: https://git.openstack.org/cgit/openstack/nova-lxd/commit/?id=4b935f860cb4299f846aec8d503d979efd7646ba
Submitter: Zuul
Branch: stable/rocky

commit 4b935f860cb4299f846aec8d503d979efd7646ba
Author: Alex Kavanagh <email address hidden>
Date: Mon Sep 3 11:33:57 2018 +0100

    Fix bug in scenario/manager and cover it with pep8

    manager.py had a syntax error which caused the module to be not
    installable. This wasn't picked up in testing. This fixes the bug
    and adds pep8 coverage to the nova_lxd_tempest_plugin so that the module
    always remains installable.

    Also, this fixes the tempest concurrency at 1. See the related bugs.

    Closes-bug: #1790956
    Related-Bug: #1790943
    Change-Id: Ie542b062a9f0997f6363877ff03f0f9bfc8f3d43
    (cherry picked from commit c4c16bcf497ef77119509f6ab63a3b769e41e9be)

[Corey Bryant (corey.bryant)]

In Ubuntu this fix is available in nova-lxd 18.0.0-0ubuntu1.