Reproducer is broken when tries to apply jobs changes to itself
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
Critical
|
Sagi (Sergey) Shnaidman |
Bug Description
download and run reproducer of this job:
+ [[ multinode-
+ [[ multinode-
+ set -x
+ export WORKSPACE
+ export ZUUL_CHANGES
+ mkdir -p /home/sshnaidm/
+ cd /home/sshnaidm/
+ rm -rf tripleo-quickstart tripleo-
+ git clone https:/
Cloning into 'tripleo-
remote: Counting objects: 13600, done.
remote: Compressing objects: 100% (40/40), done.
remote: Total 13600 (delta 12), reused 21 (delta 2), pack-reused 13558
Receiving objects: 100% (13600/13600), 2.26 MiB | 6.57 MiB/s, done.
Resolving deltas: 100% (8297/8297), done.
+ git clone https:/
Cloning into 'tripleo-
remote: Counting objects: 12962, done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 12962 (delta 1), reused 3 (delta 0), pack-reused 12953
Receiving objects: 100% (12962/12962), 2.77 MiB | 5.06 MiB/s, done.
Resolving deltas: 100% (8200/8200), done.
+ for CR in ${ZUUL_CHANGES//^/ }
+ [[ openstack/
+ pushd /home/sshnaidm/
+ git fetch https:/
remote: Counting objects: 11, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 6 (delta 5), reused 4 (delta 3)
Unpacking objects: 100% (6/6), done.
From https:/
* branch refs/changes/
+ git cherry-pick --allow-empty FETCH_HEAD
error: could not apply 66f3f1e... Log collection: sorted rpm -qa for containers
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
patch https:/
Needless to say that this is not required for testing quickstart and extras code in job, we tested it always and cloned everything here: https:/
This change is completely redundant and has sense only in cases we want to test especially reproducing code (for example nodepool-setup role) and NOT a job. In this case one can just insert change line after cloning extras, like:
# Clone quickstart and quickstart-extras
git clone https:/
git clone https:/
pushd tripleo-
git fetch https:/
popd
In all other cases we MUST not to use changes from job in reproducers code, as it:
a) breaks design of reproducer which is external tool for running builds
b) will cause bugs as above, when we can't reproduce passed job
c) will not allow us to run up to date reproducer in jobs
d) will not allow us to reproduce jobs which were running in time when reproducer was broken, because the patch above will bring all these breakages to reproducer script again.
Fixing this by revert: https:/ /review. openstack. org/#/c/ 599201/