The final message in collectors doesn't show the points of all players anymore

Bug #1790456 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

The final message in collectors doesn't show the points of all players anymore (at one place) --> regression

https://wl.widelands.org/forum/topic/2786/?page=16#post-25923

Needs more detailed description and maybe a screenshot.

Related branches

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

did some tests to confirm this bug. In General this bug has 2 parts.

First part:
in b19 the final message (game summary) had 4 columns: "player", "team", "status", "time". Additionally there was a separate area where "player information" was shown. In this area the points of e.g. collectors for the player were shown.
in b20 the columns "status" and "time" are missing. This is a clear bug

Second part:
It would make sense to have a 5th column "points" instead of showing them in the extra area. This is a wishlist item.

I haven't identified the root cause yet. However the 4 columns are still defined in src/wui/game_summary.cc but aren't shown. perhaps the width of the columns had changed so the last 2 columns aren't shown anymore

Changed in widelands:
status: New → Confirmed
Revision history for this message
GunChleoc (gunchleoc) wrote :

I addition to the player points, we could also have team points shown.

tags: added: regression ui
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I found a solution to get back the state od b19. Although I don't really understand why this works, or how it works

Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → hessenfarmer (stephan-lutz)
Changed in widelands:
status: In Progress → Fix Committed
assignee: hessenfarmer (stephan-lutz) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.