contrail-vrouter-agent-dpdk container may interfere with system wide huge pages configuration

Bug #1790130 reported by Michal Skalski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
In Progress
Undecided
Unassigned
Trunk
In Progress
Undecided
Unassigned

Bug Description

contrail-vrouter-agent-dpdk container dynamically allocates HugePages during initialisation [1]. Script responsible for it operates on default HP size which are outside of it competence thus end result may vary depends on system configuration of default HP size.
For example if we will keep default value (1024 HP) on system configured with default size of 1GB then on common servers it will usually lead to situation when there is not enough memory for system processes. It can also colide with existing system configuration when there is more HP allocated than value passed to container which will lead to decreasing pool of avaiable HP on host.

I would like to move logic of HP allocation outside docker container as this affects whole host machine. Deployers can be a better choice as they can manage default size of HP and use more predictable method of preallocating HP during machine boot.

RHOSP13/CC13 is doing that here [2] and ansible deployer can implement the same I belive [3].

[1] https://github.com/Juniper/contrail-container-builder/blob/R5.0/containers/vrouter/agent-dpdk/entrypoint.sh#L41
[2] https://github.com/Juniper/contrail-tripleo-heat-templates/blob/stable/queens/extraconfig/pre_network/contrail/contrail_ansible_kernel_config.yaml
[3] https://github.com/Juniper/contrail-ansible-deployer/blob/R5.0/playbooks/roles/configure_instances/tasks/RedHat_kernel.yml

summary: - vrouter-agent-dpdk container may interfere with system wide huge pages
- configuration
+ contrail-vrouter-agent-dpdk container may interfere with system wide
+ huge pages configuration
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45917
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45917
Committed: http://github.com/Juniper/contrail-container-builder/commit/351c89e8b06c5e6e8775dae97f3a60ce6e47da9c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 351c89e8b06c5e6e8775dae97f3a60ce6e47da9c
Author: Michal Skalski <email address hidden>
Date: Fri Aug 31 14:47:53 2018 +0200

Prefer HP allocation outside docker container

HP allocation should be done outside docker container as this affects
whole host machine. Deployers can be a better choice as they can manage
default size of HP and use more predictable method of preallocating HP
during machine boot. More information in bug description.

Change-Id: I93adc1b7a1a9753da75170beee5ae2c3c4640d7a
Partial-Bug: 1790130

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/45934
Submitter: Michal Skalski (<email address hidden>)

information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45934
Committed: http://github.com/Juniper/contrail-container-builder/commit/9164e1cb8bd6e80027fbb34a5031b6f8f48ff807
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 9164e1cb8bd6e80027fbb34a5031b6f8f48ff807
Author: Michal Skalski <email address hidden>
Date: Fri Aug 31 14:47:53 2018 +0200

Prefer HP allocation outside docker container

HP allocation should be done outside docker container as this affects
whole host machine. Deployers can be a better choice as they can manage
default size of HP and use more predictable method of preallocating HP
during machine boot. More information in bug description.

Change-Id: I93adc1b7a1a9753da75170beee5ae2c3c4640d7a
Partial-Bug: 1790130
(cherry picked from commit 351c89e8b06c5e6e8775dae97f3a60ce6e47da9c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.