Unable to start service virtualbmc@compute_0 with virtualbmc>=1.4

[Sorin Sbarnea]

New package version for virtualbmc has landed.
Unfortunately virtualbmc>=1.4 requires different setup steps than versions before and we need to take care of these.

Promotion jobs are failing in the pipeline with errors on vbmc service not starting.

Work is done on https://review.openstack.org/#/c/598095/ for covering this use case.

[Carlos Goncalves (cgoncalves)]

TASK [virtbmc : set vbmc address fact for default libvirt network] ************************************************************************************************************************************************
task path: /home/cgoncalves/dev/repos/openstack/tripleo-quickstart/roles/virtbmc/tasks/configure-vbmc.yml:55
Thursday 30 August 2018 20:01:46 +0200 (0:00:00.126) 0:07:55.072 *******
skipping: [undercloud] => {"changed": false, "skip_reason": "Conditional result was False"}

TASK [virtbmc : set qemu uri for qemu:///system usage] ************************************************************************************************************************************************************
task path: /home/cgoncalves/dev/repos/openstack/tripleo-quickstart/roles/virtbmc/tasks/configure-vbmc.yml:62
Thursday 30 August 2018 20:01:46 +0200 (0:00:00.070) 0:07:55.142 *******
skipping: [undercloud] => {"changed": false, "skip_reason": "Conditional result was False"}

TASK [virtbmc : set qemu uri for qemu:///session usage] ***********************************************************************************************************************************************************
task path: /home/cgoncalves/dev/repos/openstack/tripleo-quickstart/roles/virtbmc/tasks/configure-vbmc.yml:67
Thursday 30 August 2018 20:01:46 +0200 (0:00:00.078) 0:07:55.220 *******
ok: [undercloud] => {"ansible_facts": {"vbmc_libvirt_uri": "qemu+ssh://stack@192.168.23.1/session?socket=/run/user/1001/libvirt/libvirt-sock&keyfile=/root/.ssh/id_rsa_virt_power&no_verify=1&no_tty=1"}, "changed": false}

TASK [virtbmc : Create the Virtual BMCs] **************************************************************************************************************************************************************************
task path: /home/cgoncalves/dev/repos/openstack/tripleo-quickstart/roles/virtbmc/tasks/configure-vbmc.yml:72
Thursday 30 August 2018 20:01:46 +0200 (0:00:00.113) 0:07:55.334 *******
changed: [undercloud] => (item={u'flavor': u'control', u'default_name': u'overcloud-controller-0', u'virtualbmc_port': 6230, u'hostnamemap_override': u'overcloud-controller-foo-0', u'name': u'control_0'}) => {"changed": true, "cmd": ["vbmc", "add", "control_0", "--port", "6230", "--libvirt-uri", "qemu+ssh://stack@192.168.23.1/session?socket=/run/user/1001/libvirt/libvirt-sock&keyfile=/root/.ssh/id_rsa_virt_power&no_verify=1&no_tty=1"], "delta": "0:00:09.011731", "end": "2018-08-30 18:01:56.044814", "item": {"default_name": "overcloud-controller-0", "flavor": "control", "hostnamemap_override": "overcloud-controller-foo-0", "name": "control_0", "virtualbmc_port": 6230}, "rc": 0, "start": "2018-08-30 18:01:47.033083", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
changed: [undercloud] => (item={u'flavor': u'compute', u'default_name': u'overcloud-novacompute-0', u'virtualbmc_port': 6231, u'hostnamemap_override': u'overcloud-novacompute-bar-0', u'name': u'compute_0'}) => {"changed": true, "cmd": ["vbmc", "add", "compute_0", "--port", "6231", "--libvirt-uri", "qemu+ssh://stack@192.168.23.1/session?socket=/run/user/1001/libvirt/libvirt-sock&keyfile=/ro...

[Gabriele Cerami (gcerami)]

Proposed fixes:

https://review.openstack.org/598095
https://review.rdoproject.org/r/#/c/16044/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/598095
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=54caad2db5307870b4c0a6ee9f48e5f6b6fa8f43
Submitter: Zuul
Branch: master

commit 54caad2db5307870b4c0a6ee9f48e5f6b6fa8f43
Author: Ilya Etingof <email address hidden>
Date: Thu Aug 30 10:54:56 2018 +0200

    Handle VirtualBMC 1.4.0+ setup

    VirtualBMC 1.4.0+ RPM includes systemd unit file.

    Make use of systemd unit file if we are running Rocky+
    (implies VirtualBMC 1.4.0+) or keep old way of VirtualBMC
    deployment otherwise.

    Because of the differences in the shipped systemd unit file
    versus the one that this playbook has been creating at
    run time, we need an extra recipe to start VirtualBMC 1.4.0+
    instances.

    Change-Id: I047ce7d545a3dcbc3508d017d360b9c03fa895b9
    Partial-Bug: #1790109