Usability: can edit keyboard shortcut with symbol such as : , .

Bug #179004 reported by cathyli
4
Affects Status Importance Assigned to Milestone
Moblin Applets
Fix Released
Medium
ToddBrandt

Bug Description

Usability: can edit keyboard shortcut with symbol such as : , . Suggest user cannot edit shortcut with symbol, because it will launch applications once user type using this keys. Shortcut should only be edited by Ctrl,Alt,shift mixed with character,symbol,number.

Reproduced steps:
----------------
1. launch buttons from settings
2. Edit one action (such as calculator) shortcut with symbol .

Current result:
----------------
In step2, edit shortcut successfully and can launch the action (such as calculator) with "." If user input . many times in other places, it will launch many calculator instances and make trouble for user.

Expected result:
----------------
In step2, it should not allow user to edit shortcut only with symbol.

cathyli (cathy-li)
Changed in moblin-applets:
assignee: nobody → todd-e-brandt
importance: Undecided → Medium
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

easy fix. The key filter function in the moblin-settings-daemon code should exclude the isprint range of ascii characters and pop up a warning. It does this already for isalnum I believe.

Changed in moblin-applets:
status: New → Confirmed
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

Raji, can you take a look at this?

Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

I don't want to filter on what a user *can* use, since there may be unknown hardware buttons mapped into part of the ascii range of the keycode space, but I think it may be prudent to filter out the whole range of printable ascii characters. i.e. whatever passes g_ascii_isprint can't be bound.

fixed in 0.25

Changed in moblin-applets:
status: Confirmed → Fix Committed
cathyli (cathy-li)
Changed in moblin-applets:
milestone: none → m9
Revision history for this message
cathyli (cathy-li) wrote :

Verified in applets 0.25, it is fixed.close the issue.

Changed in moblin-applets:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.