tripleo-quickstart fails to generate /home/stack/containers-default-parameters.yaml

[Steven Hardy]

Since we made containerized undercloud and overcloud the default, you shouldn't really need to specify it explicitly in the quickstart config, e.g:

containerized_undercloud: true
containerized_overcloud: true

However if you omit both of these we fail to generate {{ working_dir }}/containers-prepare-parameter.yaml which then breaks overcloud-prep-containers

The problem seems to be lack of defaults in quickstart and/or defaults to the conditional here:

https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/undercloud-deploy/tasks/create-scripts.yml#L114

So I guess we need to either remove the when clause, or change the defaults to ensure containerized_(under|overcloud) defaults to true.

[Marios Andreou (marios-b)]

am looking into this since it is happening on the (non voting) tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates e.g. in [1][2][3] like

 ERROR openstack CommandError: Error: The following files were not found: /home/zuul/containers-default-parameters.yaml

Trouble is I can see that featureset037 is in use here from [4] and that already has containerized_overcloud set to true [5].

[1] http://logs.openstack.org/26/597726/2/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/34943de/logs/undercloud/home/zuul/overcloud_update_prepare.log.txt.gz#_2018-09-04_02_06_55 "
[2] http://logs.openstack.org/45/560445/132/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/0258722/logs/undercloud/home/zuul/overcloud_update_prepare.log.txt.gz#_2018-09-04_01_58_07
[3] http://logs.openstack.org/27/595527/4/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/333ff30/logs/undercloud/home/zuul/overcloud_update_prepare.log.txt.gz#_2018-09-04_11_01_57
[4] http://logs.openstack.org/27/595527/4/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/333ff30/logs/playbook_executions.log
[5] https://github.com/openstack/tripleo-quickstart/blob/87e7ab931f14ae05aec513110732d865a7e8dfb8/config/general_config/featureset037.yml#L27

[Jose Luis Franco (jfrancoa)]

Solved by https://review.openstack.org/#/c/599605/

[Quique Llorente (quiquell)]

It's a promotion blocker, featureset037 it's a promotion criteria for master.

[Quique Llorente (quiquell)]

Looks like OVB jobs are broken http://logs.rdoproject.org/05/599605/9/openstack-check/legacy-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-master/0ec085d/logs/undercloud/var/lib/mistral/overcloud/ansible.log.txt.gz
"jq: error: Could not open file /var/lib/heat-config/deployed/c6ef6b9a-87bd-47e8-9af4-8ccbec33560f.notify.json: No such file or directory"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/599605
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=3fd28a0d789e2dc6c9b245b09a0a70376d947b27
Submitter: Zuul
Branch: master

commit 3fd28a0d789e2dc6c9b245b09a0a70376d947b27
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue Sep 4 15:54:57 2018 +0200

    Use containers-prepare-parameters in upgrades/updates jobs.

    The output from the containers image prepare
    step is not the containers-default-parameters.yaml
    file with the list of containers, but another file
    named containers-prepare-parameters.yaml which
    contains the ContainerImagePrepare parameter. This
    parameter is used during deployment-steps to get
    the list of containers.

    Co-Authored-By: Quique Llorente <email address hidden>

    Closes-Bug: #1789881
    Depends-On: If0c7786059f1d0d91d2279f45c67525908633378
    Depends-On: I96109c2452d7568da4a9374661a8ba8b9ba71458
    Change-Id: I9bd21b67a9bf9254458351e8ba784ed66f9949f4

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart 2.1.1 release.