[2.5] When user clicks 'check power' over UI, errors are not logged

[Andres Rodriguez]

I was trying to debug issues with a BMC and noticed that when the user clicks 'check power' in the UI, errors are not logged in rackd.log.

If I try, however, to perform an action (such as commissioning), the error is logged in rackd.log (but they don't specify to which machine this applies).

   File "/usr/lib/python3/dist-packages/provisioningserver/rpc/power.py", line 290, in change_power_state
     system_id, hostname, power_type, power_change, context)
   File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 1384, in _inlineCallbacks
     result = result.throwExceptionIntoGenerator(g)
   File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line 408, in throwExceptionIntoGenerator
     return g.throw(self.type, self.value, self.tb)
   File "/usr/lib/python3/dist-packages/provisioningserver/drivers/power/__init__.py", line 379, in perform_power
     power_func, system_id, context)
   File "/usr/lib/python3/dist-packages/twisted/python/threadpool.py", line 250, in inContext
     result = inContext.theWork()
   File "/usr/lib/python3/dist-packages/twisted/python/threadpool.py", line 266, in <lambda>
     inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
   File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 122, in callWithContext
     return self.currentContext().callWithContext(ctx, func, *args, **kw)
   File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 85, in callWithContext
     return func(*args,**kw)
   File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 233, in wrapper
     result = func(*args, **kwargs)
   File "/usr/lib/python3/dist-packages/provisioningserver/drivers/power/amt.py", line 408, in power_on
     amt_command = self._get_amt_command(ip_address, power_pass)
   File "/usr/lib/python3/dist-packages/provisioningserver/drivers/power/amt.py", line 363, in _get_amt_command
     'exception')(error_info.get('message'))
 provisioningserver.drivers.power.PowerAuthError: Incorrect password. Check BMC configuration and try again.

So I think there's some improvements to be made here:

1. On *manual* check power, if there's error, it should be logged (and displayed in the UI. For the UI there's a different bug report [1])
2. Log should include which machine this was performed for.

[1]: https://bugs.launchpad.net/maas/+bug/1789707

[Adam Collard (adam-collard)]

This bug has not seen any activity in the last 6 months, so it is being automatically closed.

If you are still experiencing this issue, please feel free to re-open.

MAAS Team