unit tests fail

[Corey Bryant]

I'm trying to package 13.0.0 for Ubuntu and am hitting the following test failure:

==============================
Failed 1 tests - output below:
==============================

networking_l2gw.tests.unit.db.ovsdb.test_idl_impl.SimpleIdlTests.test_list_physical_switches
--------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/usr/lib/python2.7/dist-packages/neutron/tests/base.py", line 140, in func
        return f(self, *args, **kwargs)
      File "networking_l2gw/tests/unit/db/ovsdb/test_idl_impl.py", line 58, in test_list_physical_switches
        return_value=ovs.jsonrpc.Session(None, None)
    TypeError: __init__() takes exactly 4 arguments (3 given)

And when I run tox -e py27 on stable/rocky upstream branch I get 18 failures! The tracebacks all end with:

      File "/home/corey/pkg/rocky/upstream/networking-l2gw/.tox/py27/local/lib/python2.7/site-packages/neutron/plugins/common/constants.py", line 28, in <module>
        'router': constants.L3,
    AttributeError: 'module' object has no attribute 'L3'

[Corey Bryant (corey.bryant)]

The initial error reported above is due to a change in ovs 2.10. Upper-constraints is at 2.9.2 so this doesn't yet officially affect upstream code.

 class Session(object):
     """A JSON-RPC session with reconnection."""

- def __init__(self, reconnect, rpc):
+ def __init__(self, reconnect, rpc, remotes):

[Corey Bryant (corey.bryant)]

I'm attaching the patch that we'll carry in Ubuntu.

[Lajos Katona (lajos-katona)]

Hi Corey, if I understand well this bug can be closed in networking-l2gw, am I right?

[Corey Bryant (corey.bryant)]

Hi Lajos, I think it needs to be fixed upstream once ovs 2.10 is supported.

[Lajos Katona (lajos-katona)]

Thanks Corey