[RFE] Add native OVSDB implementation for OvsdbMonitor

Bug #1789592 reported by Bernard Cafarelli
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
New
Wishlist
Unassigned

Bug Description

This is a follow-up to https://bugs.launchpad.net/neutron/+bug/1788865

In openvswitch agent, we added native ovsdb support for most calls, but OvsDbMonitor still only supports the CLI subprocess call + output parsing, on ovsdb-client.

We should add a native OVSDB implementation to directly use the API, handling the received events (integrated in ovs_lib?). This would avoid the processes handling, parsing breakages like recent https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350795.html

This could use the same existing ovsdb_interface configuration parameter.

Revision history for this message
Miguel Lavalle (minsel) wrote :

Sounds reasonable to me. Let's see what the drivers have to say

Changed in neutron:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: rfe-triaged
removed: rfe
Revision history for this message
Slawek Kaplonski (slaweq) wrote :

One note: ovsdb_interface is already deprecated and should be removed in the future

Revision history for this message
Bernard Cafarelli (bcafarel) wrote :

Indeed I suggested it as a migration option, but just moving to API calls directly works too of course

Revision history for this message
Miguel Lavalle (minsel) wrote :

This RFE was discussed and approved on October 5th.

@Bernard,

Will you implement it?

tags: added: rfe-approved
removed: rfe-triaged
Revision history for this message
Bernard Cafarelli (bcafarel) wrote :

Recapping IRC discussion, I plan to work on it, but probably not soon.

If anyone is interested, this can be considered free to take. I will set myself as assignee when I get to it (unless someone started working on it)

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

I asked Bernard and I'm going to start working on this one.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/612153

Changed in neutron:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/612400

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/617780

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/617780
Reason: Wrong change-id

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/623179

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/612153
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=22c9cf3d95c3d14351045bac2920b4e0994ec42f
Submitter: Zuul
Branch: master

commit 22c9cf3d95c3d14351045bac2920b4e0994ec42f
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Nov 9 17:49:02 2018 +0000

    Add native OVSDB implementation for bridge monitor

    This patch implements an OVS bridge monitor based in the OVSDB
    native implementation (OVSDB IDL, Open vSwitch Database Interface
    Definition Language). This new implementation supersedes the CLI
    OVSDB monitor.

    Partial-Bug: #1789592

    Change-Id: I9c512d4cbd4cebf94c339231f83bbe89b37650ba

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/623179
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f999970755571244f1133dc74e43fbbd62ecf380
Submitter: Zuul
Branch: master

commit f999970755571244f1133dc74e43fbbd62ecf380
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Dec 6 10:06:19 2018 +0000

    Add debug information in BridgeCreateEvent

    Added extra information (bridge name) when a bridge creation event
    is received.

    Trivial fix: changed BridgeCreateEvent __init__ argument to "agent",
    as requested in [1].

    [1] https://review.openstack.org/#/c/612153/

    Partial-Bug: #1789592

    Change-Id: I0bca7e71fb379febfe2131566bb8c1bf8f039183

Revision history for this message
Slawek Kaplonski (slaweq) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in neutron:
assignee: Rodolfo Alonso (rodolfo-alonso-hernandez) → nobody
status: In Progress → New
tags: added: timeout-abandon
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/612400
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

tags: added: ovsdb-lib
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/735201

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
Slawek Kaplonski (slaweq) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in neutron:
assignee: Rodolfo Alonso (rodolfo-alonso-hernandez) → nobody
status: In Progress → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.opendev.org/735201
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.