Stop hardcoding OS_BAREMETAL_API_VERSION in stackrc

Bug #1789392 reported by Dmitry Tantsur
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Dmitry Tantsur

Bug Description

Initially it was done because ironicclient defaulted to a really ancient version (from Kilo). Then we kept it to avoid pulling it breaking changes. But the last really breaking change in Ironic was in API version 1.11 in Liberty (!), and our behavior causes neverending confusion, since it differs from upstream defaults. For example, this is what you get in the undercloud:

$ openstack baremetal node trait list host2
Requested API version 1.34 is not supported by the server, client, or
the requested operation is not supported by the requested
version.Supported version range is 1.1 to 1.37

(side note: we should really fix this error message in ironicclient).

Initially reported in https://bugzilla.redhat.com/show_bug.cgi?id=1620232.

Dmitry Tantsur (divius)
description: updated
tags: added: queens-backport-potential rocky-backport-potential
Changed in tripleo:
status: Triaged → In Progress
Dmitry Tantsur (divius)
Changed in tripleo:
milestone: none → stein-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/597036

Dmitry Tantsur (divius)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/597036
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=97298707451df065351ce002b8875830afc9d008
Submitter: Zuul
Branch: master

commit 97298707451df065351ce002b8875830afc9d008
Author: Dmitry Tantsur <email address hidden>
Date: Tue Aug 28 11:58:03 2018 +0200

    Stop hardcoding baremetal API version in stackrc

    Long time ago it was required because ironicclient defaulted to
    an ancient version. It was changed back in Queens (ironicclient 2.0),
    so we can drop it now to avoid confusion.

    Change-Id: Icea0bdf6d5dcdd81ce9c34be7af8a241da0861bc
    Closes-Bug: #1789392

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/597457

Revision history for this message
Oliver Walsh (owalsh) wrote :

@Lee, wonder if we need to do the same for nova client

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/597457
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=128347fbd724a77e4a603d2e18b59fc58604ec89
Submitter: Zuul
Branch: stable/rocky

commit 128347fbd724a77e4a603d2e18b59fc58604ec89
Author: Dmitry Tantsur <email address hidden>
Date: Tue Aug 28 11:58:03 2018 +0200

    Stop hardcoding baremetal API version in stackrc

    Long time ago it was required because ironicclient defaulted to
    an ancient version. It was changed back in Queens (ironicclient 2.0),
    so we can drop it now to avoid confusion.

    Change-Id: Icea0bdf6d5dcdd81ce9c34be7af8a241da0861bc
    Closes-Bug: #1789392
    (cherry picked from commit 97298707451df065351ce002b8875830afc9d008)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.0.0.0rc2

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.0.0

This issue was fixed in the openstack/tripleo-heat-templates 10.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to instack-undercloud (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/680697

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to instack-undercloud (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/680698

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to instack-undercloud (stable/rocky)

Reviewed: https://review.opendev.org/680697
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=91016ffeef11ff657e30d7b0487a0935daf4b8c6
Submitter: Zuul
Branch: stable/rocky

commit 91016ffeef11ff657e30d7b0487a0935daf4b8c6
Author: Dmitry Tantsur <email address hidden>
Date: Fri Sep 6 16:09:01 2019 +0200

    Stop hardcoding baremetal API version in stackrc

    Long time ago it was required because ironicclient defaulted to
    an ancient version. It was changed back in Queens (ironicclient 2.0),
    so we can drop it now to avoid confusion.

    This is the same as change Icea0bdf6d5dcdd81ce9c34be7af8a241da0861bc,
    but adapter to instack-undercloud.

    Change-Id: I106f5dc0ed4c3a3b67d8fc94c69b2b2f1d8fc547
    Closes-Bug: #1789392

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to instack-undercloud (stable/queens)

Reviewed: https://review.opendev.org/680698
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=8ca36be4d8d6a62633ff480290ad42168faf1ace
Submitter: Zuul
Branch: stable/queens

commit 8ca36be4d8d6a62633ff480290ad42168faf1ace
Author: Dmitry Tantsur <email address hidden>
Date: Fri Sep 6 16:09:01 2019 +0200

    Stop hardcoding baremetal API version in stackrc

    Long time ago it was required because ironicclient defaulted to
    an ancient version. It was changed back in Queens (ironicclient 2.0),
    so we can drop it now to avoid confusion.

    This is the same as change Icea0bdf6d5dcdd81ce9c34be7af8a241da0861bc,
    but adapter to instack-undercloud.

    Change-Id: I106f5dc0ed4c3a3b67d8fc94c69b2b2f1d8fc547
    Closes-Bug: #1789392
    (cherry picked from commit 91016ffeef11ff657e30d7b0487a0935daf4b8c6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/instack-undercloud rocky-eol

This issue was fixed in the openstack/instack-undercloud rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/instack-undercloud queens-eol

This issue was fixed in the openstack/instack-undercloud queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.