requests should be declared in requirements.txt instead of test-requirements

Bug #1789040 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

requests is used in openstack_dashboard/exceptions.py, but it is only declared in requests in test-requirements.txt. It should be declared in requirements.txt.

Revision history for this message
Akihiro Motoki (amotoki) wrote :
Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
importance: Undecided → Medium
status: New → In Progress
milestone: none → stein-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/596552
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=de3e48479893c3a2d23a5b05654674fcf839ceda
Submitter: Zuul
Branch: master

commit de3e48479893c3a2d23a5b05654674fcf839ceda
Author: Akihiro Motoki <email address hidden>
Date: Sun Aug 26 03:48:46 2018 +0900

    Move requests to requirements.txt

    requests is used in non-test code in horizon
    (openstack_dashboard/exceptions.py).
    It should be declared in requirements.txt.

    Closes-Bug: #1789040
    Change-Id: I325b5344d45f797d256bb213093082927068a88e

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 15.0.0.0b1

This issue was fixed in the openstack/horizon 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.