What's the use of /share/ui/keybindings.rc?

Bug #1789015 reported by Hachmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
Qantas94Heavy

Bug Description

There's a second keybindings file (similar to keys.xml, but much more incomplete) in the /share/ui/ directory.

It has been last edited 13 years ago.

I've tried modifying random entries in it, and that didn't make a difference.

Is this file used at all? If not, can it be removed to reduce confusion?

Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :

There was previously code for Gtk::AccelMap::load to load the file and use that for menu keyboard shortcuts. This has long since been removed and presumably replaced with some other way of handling this: https://gitlab.com/inkscape/inkscape/commit/222304de408e85f01ace7b5ec9f965440ff1079e

It seems this was only ever used by Application::Editor, which was apparently part of a failed attempt to refactor Inkscape code around gtkmm. https://gitlab.com/inkscape/inkscape/commit/be8029ed57d68a7b8e94cfc5b82984a8b1c75e55

As such, I think this should be safe to remove.

Changed in inkscape:
status: New → Triaged
importance: Undecided → Low
tags: added: shortcuts
tags: added: code-design
Changed in inkscape:
milestone: none → 1.0
Revision history for this message
Hachmann (marenhachmann) wrote :

Thank you, Qantas94Heavy!

Changed in inkscape:
assignee: nobody → Qantas94Heavy (qantas94heavy)
Hachmann (marenhachmann)
Changed in inkscape:
status: Triaged → Fix Committed
Max Gaukler (mgmax)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.