Contrail 5.0.1GA: workflow to delete a compute from an existing cluster

[Luke Bockelmann]

This URL describes a procedure to add a compute: https://github.com/Juniper/contrail-ansible-deployer/wiki/Adding-a-new-compute-node-to-an-already-existing-contrail-openstack-cluster

Today we don't have a GA procedure for it. Until we have a coded workflow, we have to use config APIs to delete.

Shivayogi knows these API's but we need a workflow.

This would account for any misconfigurations of a compute that needs to be fixed during the deployment.

[Luke Bockelmann (h-luke)]

In older release we used fab in which we had detach_vrouter task.

Detatach_vrouter does the following,
1. Stops Nova compute
2. Stops supervisor-vrouter
3. Exeecutes provision_vrouter.py with --del option and the IP details of the compute/api-server
Reference: https://github.com/Juniper/contrail-fabric-utils/blob/master/fabfile/tasks/misc.py#L47

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46565
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46549
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46565
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46549
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[Nitish Krishna Kaveri (nitishk)]

Per discussion with Abhay, Alex and Andrey, we are pausing work on Add/Delete on any role till we have a common Spec/Blueprint to do this for ALL supported orchestrators to maintain release feature parity.

This is now slated for 5.1

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46656
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/46656
Committed: http://github.com/Juniper/contrail-specs/commit/a0e586ab25a7855603fc1734b46d2f8560c8ada2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit a0e586ab25a7855603fc1734b46d2f8560c8ada2
Author: nitishkrishna <email address hidden>
Date: Tue Oct 2 11:03:11 2018 -0700

Add Delete Roles Spec file

Blueprint :
https://blueprints.launchpad.net/opencontrail/+spec/add-delete-nodes-roles

Partial-Bug: #1788447

Patch: re-wrote based on review comments.

Change-Id: I7daebe590889f0971dc31b7185d49e0e1c3dd0e9

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47259
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47424
Submitter: Ignatious Johnson Christopher (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47259
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47424
Submitter: Ignatious Johnson Christopher (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47259
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47424
Committed: http://github.com/Juniper/contrail/commit/5af9fa192a3ecec6ef9f4d4823275a88eaa50624
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 5af9fa192a3ecec6ef9f4d4823275a88eaa50624
Author: Ignatious Johnson Christopher <email address hidden>
Date: Thu Nov 1 18:58:46 2018 +0000

Support delete compute

Added UT for provisioing action compute node delete.

Change-Id: I39da78d85b152cbbdd58c637057f8dae651e6d0e
Partial-Bug: 1788447

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47259
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47259
Committed: http://github.com/Juniper/contrail-ansible-deployer/commit/c2784c1e76ec25882239440d1511e0fea5fd4709
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c2784c1e76ec25882239440d1511e0fea5fd4709
Author: nitishkrishna <email address hidden>
Date: Wed Oct 24 11:49:15 2018 -0700

Initial Commit to support Add Delete of Computes

Includes:
1. Script to read existing cluster and calculate existing, new and deleted roles
2. Changes to provision/reprovision logic to only provision new Computes
3. Reprovision only when existing cluster matches new instances YAML
4. Separation of De-Registering/ Deleting logic

Patch:
Webui and Config Database Not supported due to bugs:
Supporting add/delete of Config DB - https://bugs.launchpad.net/juniperopenstack/+bug/1799269 - Discussed with Shivayogi, will take Satish help to fix
Support add/delete of Web UI - https://bugs.launchpad.net/juniperopenstack/+bug/1799270 - Will have to be fixed with help from Biswajit/Sarin

Implemented review comments
Python requests package will be installed elsewhere

Partial-Bug: #1788447

Change-Id: I4c2ec8b8e605863e4767f06cab5ef40037d07457

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47737
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47737
Committed: http://github.com/Juniper/contrail/commit/58d3e0a72b06bedfde2740b358f6a92d13d1be19
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 58d3e0a72b06bedfde2740b358f6a92d13d1be19
Author: nitishkrishna <email address hidden>
Date: Mon Nov 19 12:16:29 2018 -0800

Adding python-requests dependency for Contrail-Ansible-Deployer

Needed for filter plugin in change:
https://review.opencontrail.org/#/c/47259/

Change-Id: Iaf41e597c2f59050145d8a568aec004faa1f7c9f
Partial-Bug: #1788447

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47908
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47908
Committed: http://github.com/Juniper/contrail/commit/6df960dd3cdf68e7924f2cfdd52e24d322064de4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 6df960dd3cdf68e7924f2cfdd52e24d322064de4
Author: nitishkrishna <email address hidden>
Date: Mon Nov 19 12:16:29 2018 -0800

Adding python-requests dependency for Contrail-Ansible-Deployer

Needed for filter plugin in change:
https://review.opencontrail.org/#/c/47259/

Change-Id: Iaf41e597c2f59050145d8a568aec004faa1f7c9f
Partial-Bug: #1788447
(cherry picked from commit 58d3e0a72b06bedfde2740b358f6a92d13d1be19)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47959
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47959
Committed: http://github.com/Juniper/contrail-specs/commit/0717f41c441081c3d71d35a800fb0d7fe13f8b4c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0717f41c441081c3d71d35a800fb0d7fe13f8b4c
Author: nitishkrishna <email address hidden>
Date: Fri Nov 30 11:53:24 2018 -0800

Added Scope information for cluster management

Blueprint :
https://blueprints.launchpad.net/opencontrail/+spec/add-delete-nodes-roles

Change-Id: I15f94c9ccb085622a443ae6fb78a9e58c5e0f91c
Closes-Bug: #1788447

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47984
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47984
Committed: http://github.com/Juniper/contrail-ansible-deployer/commit/a2d150de2dffcaed1758da46abd83e4c3988add9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit a2d150de2dffcaed1758da46abd83e4c3988add9
Author: nitishkrishna <email address hidden>
Date: Mon Dec 3 10:59:54 2018 -0800

Config API node needs to have facts to check if it is Linux

For code:
when:
- ('vrouter' in node_roles_dict[instance_name].deleted_roles)
- ansible_system == 'Linux'

in playbooks/roles/contrail/tasks/deregister.yml

Closes-Bug: #1788447

Change-Id: I4146ec4db43e62178d7b120b1b747dcb14fd7adb