Web client: Libraries w/out vols/copies not alpha order

[Elaine Hardy]

Reported this initially as part of https://bugs.launchpad.net/evergreen/+bug/1715697

In holdings view, libraries without volumes are not displaying in alpha order and are not aligning correctly. With view set for one system, display is similar to:

ARL ... ARL-ATH DVD SHAUN AV 31001002449396
 ARL-WAT DVD SHAUN AV 31001003455558
        ARL ... ARL-BOG
    ARL ... ARL-LEX
        ARL ... ARL-DAN
          ARL ... ARL-WINT
ARL ... ARL-LAV
   ARL ... ARL-ROY
      ARL ... ARL-ENSAT
     ARL ... ARL-LYNDON
   ARL ... ARL-BKM
 ARL ... ARL-EAST
       ARL ... ARL-LAY
ARL ... ARL-PWOODS

The display should be:

ARL ... ARL-ATH DVD SHAUN AV 31001002449396
ARL ... AARL-BKM
ARL ... ARL-EAST
ARL ... ARL-LAY
ARL ... ARL-LYNDON
ARL ... ARL-ROY
ARL ... ARL-BOG
ARL ... ARL-DAN
ARL ... ARL-ENSAT
ARL ... ARL-LAV
ARL ... ARL-LEX
ARL ... ARL-PWOODS
ARL …ARL-WAT DVD SHAUN AV 31001003455558
ARL ... ARL-WINT

 When view is set for consortium level, the empty libraries are added at the end of the libraries with holdings rather than within the individual library.
Currently, Show holdings at or below PINES and Show empty volumes, show empty libraries, show copy details, and show volume details are all checked, holdings are displayed as:

ARCPLS-DIAML Diamond Lakes Branch Library 31019003273979 FIC WEB
  ARCPLS-FRMAN Friedman Branch Library 31019003273987 FIC WEB
 ARCPLS-MAIN Augusta-Richmond Co. Public Lib. 31019003273961 FIC WEB
CCL-RING Catoosa County Library 31687002412309 WEBER, DAVID
CLAYTN-FOR Forest Park Branch 31012002832028 A FIC WEBER, DAVID
DCPL-CEN Central Branch 31018002661200 F WEBER, DAVID
FRRLS-FA Fayette County Public Library 31022007284679 SF WEBER
FRRLS-JA Jackson-Butts County Public Library 31022007182634 SF WEBER
MCCLS-DOE
MCCLS-BKM
    ARCPLS-MXWLL
  ARL-ATH
ARL-WAT
  ARL-BOG
ARL-LEX
Etc… for all libraries

For clarity, display should keep empty libraries/branches within library system:

ARCPLS-DIAML Diamond Lakes Branch Library 31019003273979 FIC WEB
ARCPLS-FRMAN Friedman Branch Library 31019003273987 FIC WEB
ARCPLS-MAIN Augusta-Richmond Co. Public Lib. 31019003273961 FIC WEB
ARCPLS-MXWLL
ARL-ATH
ARL-BKM
ARL-BOG
….
DCPL-CEN Central Branch 31018002661200 F WEBER, DAVID
DCPL-SS
DCPL-TAL
DCPL-WT
FRRLS-FA Fayette County Public Library 31022007284679 SF WEBER
FRRLS-FY
FRRLS-GR
FRRLS-JA Jackson-Butts County Public Library 31022007182634 SF WEBER
FRRLS-TY
…..
MCCLS ... MCCLS-BKM
MCCLS ... MCCLS-DOE
....

[Dan Pearl (dpearl)]

This seems to work on Concerto data:

user/dpearl/LP1787636_empty_lib_holdings

[Jason Stephenson (jstephenson)]

Gonna take it for a test spin and then assign targets if it works.

[Janet Schrader (jschrader)]

I tested this today and can confirm that at the consortium level when Show empty volumes, Show empty libraries, Show copy details, and Show volume details are all checked, the list of libraries is in alpha order regardless if a branch has an item or not. Empty libraries remain in alpha order as items are added to branches. Adding an item to BR4, BR4 remains at the bottom of the list.

The one thing that's not happening that I expected is the list of owning libraries is not left justified. I thought that was also going to be fixed.

[Chris Sharp (chrissharp123)]

Removing pull request pending developer feedback on the last comment or a new patch.

[Jason Stephenson (jstephenson)]

I rebased the branch on master and added a commit to address Janet's concern in comment #3. I believe the branch is now doing everything that was requested. I have pushed to a collab branch for others to test:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/LP1787636_empty_lib_holdings

[Chris Sharp (chrissharp123)]

Pushed to master, 3.3, 3.4, and 3.5. Thanks Jason, Dan, and all who tested!