Unit tests needed

[Corey Bryant]

It would be great to get some unit test coverage. There doesn't seem to be much coverage other than for smutLayer.

[jichenjc (jichenjc)]

um..are you suggesting to increase unit test coverage of sdk itself?
actually, https://github.com/mfcloud/python-zvm-sdk/tree/master/zvmsdk/tests/unit
has all the unit test cases and for each patch submitted, we will run it automatically

so I don't know what kind of additional unit test is requested

[Corey Bryant (corey.bryant)]

Ok I see what the problem is. I'm packaging this up for Ubuntu and we pull source from the published tarball which doesn't include the test directory you referenced and also doesn't include tox.ini.

[Corey Bryant (corey.bryant)]

Any chance you can include those and anything else that's needed for testing in your published tarballs?

[jichenjc (jichenjc)]

For our previous experience, usually the tgz will exclude the test files to make it easier and simple, any reason to keep those test files ?because of we want to make sure the deb file build correctly?

Anyway, we are analyzing and will include those if needed, thanks for the suggestion

[Corey Bryant (corey.bryant)]

Yes, it allows downstream maintainers to verify the package during builds. For example, unit tests will catch an outdated dependency python package, among other things. It's standard practice to include test files in release tarballs in my experience. Additionally for Ubuntu, it's difficult to get a package into (fully supported) Main repositories without having tests to run. Thanks for looking into it.

[jichenjc (jichenjc)]

ok, got your point, I will ask folks to help on this , thanks for the bug report

[Huang Rui (bjhuangr)]

https://review.gerrithub.io/c/mfcloud/python-zvm-sdk/+/423196

[Huang Rui (bjhuangr)]

1.2.4 released for including unit tests.