group_binds for provider networks has no effect on neutron provider mappings

[James Denton]

When users define provider networks in /etc/openstack_deploy/openstack_user_config.yml, group_binds are specified. User request is to ensure that provider network is configured on only the hosts matching the group. The current behavior is to add any defined provider network to all nodes running neutron agents (as seen in the agent/ml2 templates).

Example:

    - network:
        container_bridge: "br-vlan"
        container_type: "veth"
        container_interface: "eth11"
        type: "vlan"
        range: "101:200,301:400"
        net_name: "vlan"
        group_binds:
          - neutron_linuxbridge_agent
    - network:
        container_bridge: "br-vlan-pnet"
        container_type: "veth"
        container_interface: "eth50"
        host_bind_override: "ens224"
        type: "vlan"
        net_name: "physnet-pnet"
        range: "2000:2100"
        group_binds:
          - neutron_l3_agent

In this example, both networks will be configured as Neutron provider networks in the respective agent and ml2_config files despite the group_binds values:

Compute:

# ML2 VLAN networks
[ml2_type_vlan]
network_vlan_ranges = vlan:101:200,vlan:301:400,physnet-pnet:2000:2100

# Linux bridge agent physical interface mappings
[linux_bridge]
physical_interface_mappings = vlan:br-vlan,physnet-pnet:ens224

Network node:

# ML2 VLAN networks
[ml2_type_vlan]
network_vlan_ranges = vlan:101:200,vlan:301:400,physnet-pnet:2000:2100

# Linux bridge agent physical interface mappings
[linux_bridge]
physical_interface_mappings = vlan:br-vlan,physnet-pnet:ens224

The desired state is as follows:

Compute:

# ML2 VLAN networks
[ml2_type_vlan]
network_vlan_ranges = vlan:101:200,vlan:301:400

# Linux bridge agent physical interface mappings
[linux_bridge]
physical_interface_mappings = vlan:br-vlan

Network node:

# ML2 VLAN networks
[ml2_type_vlan]
network_vlan_ranges = vlan:101:200,vlan:301:400,physnet-pnet:2000:2100

# Linux bridge agent physical interface mappings
[linux_bridge]
physical_interface_mappings = vlan:br-vlan,physnet-pnet:ens224

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/592659

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/592661

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/592661
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=256163ecd27c8d50c54a7a78b9ec87e989ca0925
Submitter: Zuul
Branch: master

commit 256163ecd27c8d50c54a7a78b9ec87e989ca0925
Author: James Denton <email address hidden>
Date: Thu Aug 16 19:20:58 2018 +0000

    Modify provider_network plugin to compare group_binds to group_names

    This patch compares group_binds of a given OSA provider network to the
    group membership of a host to ensure the respective Neutron provider
    network is configured only on matching hosts.

    Change-Id: Idd13195b7f5c23badb21542dd83ab2898aae16d5
    Partial-Bug: #1787462

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/592659
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=af0f439ec931e4e9656e6ea4bbacb28539d3293a
Submitter: Zuul
Branch: master

commit af0f439ec931e4e9656e6ea4bbacb28539d3293a
Author: James Denton <email address hidden>
Date: Thu Aug 16 19:07:35 2018 +0000

    Provides group_names for use with provider_network plugin

    This patch will provide group_names to the provider network object,
    which will then be used to compare group_binds for selective
    provider network placement across nodes.

    Change-Id: I2964366ecc9052582d6eb39d1caf81027fa58271
    Partial-Bug: #1787462
    Depends-On: https://review.openstack.org/592661

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/616377

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/616378

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/616379

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/616380

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616380
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=fb0507cde470c4a3c500de5b5a013743363cd524
Submitter: Zuul
Branch: stable/queens

commit fb0507cde470c4a3c500de5b5a013743363cd524
Author: James Denton <email address hidden>
Date: Thu Aug 16 19:20:58 2018 +0000

    Modify provider_network plugin to compare group_binds to group_names

    This patch compares group_binds of a given OSA provider network to the
    group membership of a host to ensure the respective Neutron provider
    network is configured only on matching hosts.

    Change-Id: Idd13195b7f5c23badb21542dd83ab2898aae16d5
    Partial-Bug: #1787462
    (cherry picked from commit 256163ecd27c8d50c54a7a78b9ec87e989ca0925)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616377
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=55803640ceb98305e9d90a795f86bf3858576852
Submitter: Zuul
Branch: stable/rocky

commit 55803640ceb98305e9d90a795f86bf3858576852
Author: James Denton <email address hidden>
Date: Thu Aug 16 19:20:58 2018 +0000

    Modify provider_network plugin to compare group_binds to group_names

    This patch compares group_binds of a given OSA provider network to the
    group membership of a host to ensure the respective Neutron provider
    network is configured only on matching hosts.

    Change-Id: Idd13195b7f5c23badb21542dd83ab2898aae16d5
    Partial-Bug: #1787462
    (cherry picked from commit 256163ecd27c8d50c54a7a78b9ec87e989ca0925)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616379
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=3e822f2869322e0dd73dfa0dc747ec123a7ad4e8
Submitter: Zuul
Branch: stable/queens

commit 3e822f2869322e0dd73dfa0dc747ec123a7ad4e8
Author: James Denton <email address hidden>
Date: Thu Aug 16 19:07:35 2018 +0000

    Provides group_names for use with provider_network plugin

    This patch will provide group_names to the provider network object,
    which will then be used to compare group_binds for selective
    provider network placement across nodes.

    Change-Id: I2964366ecc9052582d6eb39d1caf81027fa58271
    Partial-Bug: #1787462
    Depends-On: https://review.openstack.org/#/c/616380
    (cherry picked from commit af0f439ec931e4e9656e6ea4bbacb28539d3293a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616378
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=8c8950e97dd672374d6224abccd7b422d2e77c54
Submitter: Zuul
Branch: stable/rocky

commit 8c8950e97dd672374d6224abccd7b422d2e77c54
Author: James Denton <email address hidden>
Date: Thu Aug 16 19:07:35 2018 +0000

    Provides group_names for use with provider_network plugin

    This patch will provide group_names to the provider network object,
    which will then be used to compare group_binds for selective
    provider network placement across nodes.

    Change-Id: I2964366ecc9052582d6eb39d1caf81027fa58271
    Partial-Bug: #1787462
    Depends-On: https://review.openstack.org/#/c/616377
    (cherry picked from commit af0f439ec931e4e9656e6ea4bbacb28539d3293a)