Property DockerCinderConfigImage not assigned

[wes hayutin]

2018-08-15 18:58:12 | Heat Stack create failed.
2018-08-15 18:58:12 | Heat Stack create failed.
2018-08-15 18:58:12 | END return value: 1
2018-08-15 18:58:12 | ETE state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:52Z [overcloud.ControllerServiceChain.UpgradeBatchTasks]: CREATE_IN_PROGRESS state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:52Z [overcloud.ControllerServiceChain.UpgradeBatchTasks]: CREATE_COMPLETE state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:52Z [overcloud.ControllerServiceChain.ServiceConfigSettings]: CREATE_IN_PROGRESS state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:52Z [overcloud.ControllerServiceChain.ServiceServerMetadataHook]: CREATE_IN_PROGRESS state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:52Z [overcloud.ControllerServiceChain.ServiceServerMetadataHook]: CREATE_COMPLETE state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:53Z [overcloud.ControllerServiceChain.ServiceConfigSettings]: CREATE_COMPLETE state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:53Z [overcloud.ControllerServiceChain.ExternalUpgradeTasks]: CREATE_IN_PROGRESS state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:53Z [overcloud.ControllerServiceChain.ExternalUpgradeTasks]: CREATE_COMPLETE state changed
2018-08-15 18:58:12 | 2018-08-15 18:57:53Z [overcloud.ControllerServiceChain]: CREATE_COMPLETE Stack CREATE completed successfully
2018-08-15 18:58:12 | 2018-08-15 18:57:54Z [overcloud.ControllerServiceChain]: CREATE_COMPLETE state changed
2018-08-15 18:58:12 |
2018-08-15 18:58:12 | Stack overcloud/2f5422c6-8abb-48fd-8689-ba48c2fed035 CREATE_FAILED
2018-08-15 18:58:12 |
2018-08-15 18:58:12 | overcloud.BlockStorageServiceChain.ServiceChain:
2018-08-15 18:58:12 | resource_type: OS::Heat::ResourceChain
2018-08-15 18:58:12 | physical_resource_id:
2018-08-15 18:58:12 | status: CREATE_FAILED
2018-08-15 18:58:12 | status_reason: |
2018-08-15 18:58:12 | resources.ServiceChain: Property error: resources[2].properties: Property DockerCinderConfigImage not assigned
2018-08-15 18:58:12 | + status_code=1
2018-08-15 18:58:12 | + openstack stack list
2018-08-15 18:58:12 | + grep -q overcloud

http://logs.openstack.org/46/592146/2/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/d5e6d26/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2018-08-15_18_58_12

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/592186

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/592233

[Steve Baker (steve-stevebaker)]

OK I see a problem.

This action[1] ensures there is a default value set for *every* image parameter, and renders that to a plan file environments/containers-default-parameters.yaml.

Currently environments/containers-default-parameters.yaml is not populated with any parameters at all. I'll investigate why.

[1] https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/container_images.py#L35

[Steve Baker (steve-stevebaker)]

I've run this code[1] in interactive python sessions, both on the undercloud host and inside a mistral_executor container and it populates the parameters as expected, so I'm still digging

[1] https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/container_images.py#L47-L62

[Steve Baker (steve-stevebaker)]

Ah, the next action PrepareContainerImageParameters is also writing to environments/containers-default-parameters.yaml. I'll make sure it leaves default values for all images parameters

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/592275

[OpenStack Infra (hudson-openstack)]

Change abandoned by wes hayutin (<email address hidden>) on branch: master
Review: https://review.openstack.org/592186

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/592275
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8b557554a4e8807d41350d3630ae77132cd3a313
Submitter: Zuul
Branch: master

commit 8b557554a4e8807d41350d3630ae77132cd3a313
Author: Steve Baker <email address hidden>
Date: Thu Aug 16 17:28:53 2018 +1200

    Ensure all image parameters have a default set

    Now that the PrepareContainerImageParameters action is part of the
    deploy workflow, environments/containers-default-parameters.yaml is
    overwritten with a dry-run prepare. The output of this prepare is
    filtered to *only* those images required for deployment.

    However heat requires all image parameters to be populated, regardless
    of whether they're required, so this change will ensure that a value
    is set for all image parameters by sharing the logic from the
    PrepareContainerImageEnv image (which runs during the plan creation
    workflow).

    Change-Id: Ia2f013714dafac91075456576ec421fbddd822ae
    Closes-Bug: #1787268

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/593616

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/596295

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.3.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Daniel Alvarez (<email address hidden>) on branch: master
Review: https://review.openstack.org/596295

[OpenStack Infra (hudson-openstack)]

Change abandoned by Christian Schwede (<email address hidden>) on branch: master
Review: https://review.opendev.org/593616