The Parameter (UndercloudUpgrade) was not provided.

[Dmitry Goloshubov]

The UndercloudUpgrade parameter is not defined when deploying a plan from the default templates. Looks like the cause is in the overcloud/docker/services/database/mysql.yaml, line 265:
265: when: {get_param: UndercloudUpgrade}
(the quick/ugly workaround - commenting it)

Steps to reproduce:
$ openstack overcloud deploy --templates
(or via web UI)

Expected result:
Overcloud installed successfully

Actual result:
Overcloud installation fails with the "Error in 81 output role_data: The Parameter (UndercloudUpgrade) was not provided." error

Environment:
Queens, default undercloud installation using the following repo:
https://trunk.rdoproject.org/centos7/current/python2-tripleo-repos-0.0.1-0.20180806134256.86aee5f.el7.noarch.rpm

Logs & Configs:
http://paste.openstack.org/show/728033/

[Emilien Macchi (emilienm)]

It's weird it fails in Queens, UndercloudUpgrade was introduced in Rocky. I might take a look at this one this week.

[Dmitry Goloshubov (goldmitry)]

Yes, it is. Let me know how I can help - get more info or smth.

[Emilien Macchi (emilienm)]

Are you deploying Queens or Rocky?

[Emilien Macchi (emilienm)]

I couldn't reproduce that bug neither on Queens and Rocky, please provide details of your environment if you think we need to re-open it.

[Dmitry Goloshubov (goldmitry)]

I was deploying Queens.
http://paste.openstack.org/show/728132/

It's a test libvirt/kvm/vbmc lab.

That's weird that I'm the only one who faced this issue. Probably, I missed something, but I was following step by step the installation guide http://tripleo.org/install/index.html.

There is no need to reopen the bug for now. I will try to redoploy all the things once again. Thanks.

[wes hayutin (weshayutin)]

https://logs.rdoproject.org/openstack-periodic-24hr/git.openstack.org/openstack-infra/tripleo-ci/master/legacy-periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-queens/3cd3231/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz

[wes hayutin (weshayutin)]

2018-08-19 06:42:50 | 2018-08-19 06:42:34Z [overcloud.ControllerServiceChain]: CREATE_FAILED Error in 81 output role_data: The Parameter (UndercloudUpgrade) was not provided.
2018-08-19 06:42:50 | 2018-08-19 06:42:35Z [overcloud.ControllerServiceChain]: CREATE_FAILED resources.ControllerServiceChain: Error in 81 output role_data: The Parameter (UndercloudUpgrade) was not provided.
2018-08-19 06:42:50 | 2018-08-19 06:42:35Z [overcloud]: CREATE_FAILED Resource CREATE failed: resources.ControllerServiceChain: Error in 81 output role_data: The Parameter (UndercloudUpgrade) was not provided.
2018-08-19 06:42:50 |
2018-08-19 06:42:50 | Stack overcloud CREATE_FAILED
2018-08-19 06:42:50 |
2018-08-19 06:42:50 | overcloud.ControllerServiceChain:
2018-08-19 06:42:50 | resource_type: OS::TripleO::Services
2018-08-19 06:42:50 | physical_resource_id: 8eca02ee-53a9-44ee-8942-855777efaa00
2018-08-19 06:42:50 | status: CREATE_FAILED
2018-08-19 06:42:50 | status_reason: |
2018-08-19 06:42:50 | resources.ControllerServiceChain: Error in 81 output role_data: The Parameter (UndercloudUpgrade) was not provided.
2018-08-19 06:42:50 | + status_code=1
2018-08-19 06:42:50 | + openstack stack list

[Marios Andreou (marios-b)]

just went digging here ... some notes but no root cause yet:

* this UndercloudUpgrade parameter is referenced in 2 files docker/services/database/mysql.yaml [1] where it has a default set as false, and ./environments/lifecycle/undercloud-upgrade-prepare.yaml [2] and this environment file is actually set by the python-tripleoclient at [3] if this is undercloud upgrade which is not the case here (looks like instack-undercloud@ [4]).

* I *suspect* the heat stack error [5] "resources.ControllerServiceChain: Error in 81 output role_data: The Parameter (UndercloudUpgrade) was not provided" is coming from [6] do we need to add that parameter to this template and default it to false like we are doing with [1]? But this is totally speculation still. One problem with the theory is that afaics none of those templates are new/have recent/less than 2 weeks changes afaics (or i may have missed something ) so why is the error appearing now.

[1] https://github.com/openstack/tripleo-heat-templates/blob/46ef07433632ae5639df2e53e181ec0abd0d7b34/docker/services/database/mysql.yaml#L51
[2] https://github.com/openstack/tripleo-heat-templates/blob/46ef07433632ae5639df2e53e181ec0abd0d7b34/environments/lifecycle/undercloud-upgrade-prepare.yaml#L7
[3] https://github.com/openstack/python-tripleoclient/blob/867867d141f8df98b89bd8e65b13a661a4631701/tripleoclient/v1/undercloud_config.py#L347
[4] https://logs.rdoproject.org/openstack-periodic-24hr/git.openstack.org/openstack-infra/tripleo-ci/master/legacy-periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-queens/3cd3231/logs/undercloud/home/zuul/undercloud_install.log.txt.gz
[5] https://logs.rdoproject.org/openstack-periodic-24hr/git.openstack.org/openstack-infra/tripleo-ci/master/legacy-periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-queens/3cd3231/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2018-08-19_06_42_50
[6] https://github.com/openstack/tripleo-heat-templates/blob/46ef07433632ae5639df2e53e181ec0abd0d7b34/docker/services/undercloud-upgrade.yaml#L38

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/593572

[Emilien Macchi (emilienm)]

Will be fixed by https://review.openstack.org/#/c/593572/

[Emilien Macchi (emilienm)]

Sorry Dmitry, you were right and it was a regression in https://review.openstack.org/#/c/576520/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/593572
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fdcdb90f761375f8b4ec6d23ea96fd8dfa050efb
Submitter: Zuul
Branch: stable/queens

commit fdcdb90f761375f8b4ec6d23ea96fd8dfa050efb
Author: Emilien Macchi <email address hidden>
Date: Mon Aug 20 12:35:51 2018 +0200

    undercloud/mysql: remove useless task for upgrade

    This task is only useful in Rocky, when upgrading an non containerized
    undercloud from Queens to a containerized undercloud on Rocky.
    Therefore, the parameter UndercloudUpgrade should not have been
    backported in : I2399a72709d240f84e3463c5c3b56942462d1e5c

    Closes-Bug: #1787010
    Change-Id: I2b5690dfd3662837b28c9801a0f37e785547f813

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.6 release.