tripleo

Redfish username/password should be optional

Bug #1786976 reported by Dmitry Tantsur on 2018-08-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Low	Alex Schultz	tripleo stein-1

Bug Description

They're optional in ironic [1], so we should make them optional as well.

[1] https://github.com/openstack/ironic/blob/e335287e95d0bfb45322037ed63b5c5cedfe7a9a/ironic/drivers/modules/redfish/utils.py#L50-L56

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-14: Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/591777

Changed in tripleo:
status:	Triaged → In Progress

Emilien Macchi (emilienm) on 2018-08-15

Changed in tripleo:
milestone:	none → rocky-rc1

Alex Schultz (alex-schultz) on 2018-08-21

Changed in tripleo:
milestone:	rocky-rc1 → stein-1

OpenStack Infra (hudson-openstack) on 2018-08-24

Changed in tripleo:
assignee:	Dmitry Tantsur (divius) → Alex Schultz (alex-schultz)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-27: Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/591777
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a82c4313e09eb7f81042c154385f1289e43f34f2
Submitter: Zuul
Branch: master

commit a82c4313e09eb7f81042c154385f1289e43f34f2
Author: Dmitry Tantsur <email address hidden>
Date: Tue Aug 14 18:26:58 2018 +0200

Do not require username/password when enrolling Redfish nodes

    While nearly always present, these fields are not required by ironic,
    so we should not require them as well. This simplifies testing on
    an emulator.

Change-Id: I8e7ce2312342c0572d5ba8967e4b7ac47d8401da
Closes-Bug: #1786976

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-28: Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/597025

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-30: Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.openstack.org/597025
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b1d010180b11df8b75a86ab378735f3f094ac331
Submitter: Zuul
Branch: stable/rocky

commit b1d010180b11df8b75a86ab378735f3f094ac331
Author: Dmitry Tantsur <email address hidden>
Date: Tue Aug 14 18:26:58 2018 +0200

Do not require username/password when enrolling Redfish nodes

    While nearly always present, these fields are not required by ironic,
    so we should not require them as well. This simplifies testing on
    an emulator.

    Change-Id: I8e7ce2312342c0572d5ba8967e4b7ac47d8401da
    Closes-Bug: #1786976
    (cherry picked from commit a82c4313e09eb7f81042c154385f1289e43f34f2)