Web Client: z39.50 Using TCN Instead of id

[John Merriam]

Affects web client in Evergreen 3.1.x Likely also affects 3.0.x and master.

The z39.50 interface in the web client is trying to match the TCN with the id column in biblio.record_entry That does not work in our consortium. The web client z39.50 interface is unusable for us due to this issue.

In Open-ILS/web/js/ui/default/staff/cat/z3950/app.js we see code like this:

var url = egCore.env.basePath +
        'cat/catalog/record/' + items[0].tcn();

It should probably read something like:

if global_flag-cat.bib.use_id_for_tcn == TRUE
    var url = egCore.env.basePath +
            'cat/catalog/record/' + items[0].tcn();
else
    var url = egCore.env.basePath +
            'cat/catalog/record/' + items[0].biblio.record_entry-id();

Note that the above is VERY psuedo code. I will look into this further and if I can figure out how to fix it correctly I will add a patch to this bug. I have not been able to figure out what the various elements of the item type are so far.

Also note that there are many more places in Open-ILS/web/js/ui/default/staff/cat/z3950/app.js where the same problem can be found.

We see errors like this in our logs when this bug is triggered:

open-ils.pcrud: [ERR :36321:oils_sql.c:5995:1534174243364189] open-ils.pcrud: Error retrieving biblio::record_entry with query [SELECT "bre".active, "bre".create_date, "bre".creator, "bre".deleted, "bre".edit_date, "bre".editor, "bre".fingerprint, "bre".id, "bre".last_xact_id, "bre".marc, "bre".quality, "bre".source, "bre".tcn_source, "bre".tcn_value, "bre".owner, "bre".share_depth, "bre".merge_date, "bre".merged_to FROM biblio.record_entry AS "bre" WHERE "bre".id = 'on1001456208';]: 3484946 3484946: ERROR: invalid input syntax for integer: "on1001456208"#012LINE 1: ...ROM biblio.record_entry AS "bre" WHERE "bre".id = 'on1001456...#012

This is related to (I believe what is described above is the the underlying cause for) bug 1731042

I hope that this is not an issue anywhere else besides z39.50.

[John Merriam (jmerriam)]

This patch fixes it for us. After thinking about it, I don't think it is necessary to check the global config flag I put in my pseudo code?

[Terran McCanna (tmccanna)]

See also: https://bugs.launchpad.net/evergreen/+bug/1731042