Rescue Symbols not prompting

[Seth Hillbrand]

In the attached project, a student of mine has created a schematic with some custom symbols. He shared the project, schematic and cache. I extracted the files to a new directory, opened the project and Eeschema does not prompt to rescue the symbols that only exist in the cache. Additionally, attempting to manually invoke "Rescue Symbols" gives the dialog "This project has nothing to rescue".

However, saving the project will give an error "Errors occurred creating symbol library", after which the cache file has been overwritten and the associated symbols are gone.

Application: kicad
Version: (5.0.1-dev-32-ga45a8e879), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2l zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-7-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Nick Østergaard (nickoe)]

Maybe this is related to this bug about the colon missing in the cache lib?

https://bugs.launchpad.net/bugs/1785513

[Wayne Stambaugh (stambaughw)]

@Jeff, this has been fixed in the development branch but the fix has not been merged with the 5.0 branch yet. I see your commit cb6152539 looks like it fixes this bug but I'm not sure and I don't have time to bisect it to figure it out. Do you know if there are any other commits that would impact this bug? If so please let me know so I can cherry-pick the necessary commits to fix this bug. I would like to roll out a 5.0.1 release by the end of September and there are still a few outstanding bug reports that need addressed.

[Seth Hillbrand (sethh)]

We'll need to be careful cherry-picking as it looks like there's a string change we need to avoid for 5.0.1

[Jeff Young (jeyjey)]

@Wayne, I dunno. I certainly didn't have this bug in mind when I fixed the other one, but I can see where the fix could have handled both.

I can't think of anything else that could impact this, but then again I had forgotten about the commit you did find, so take all that with a grain of salt....

[Wayne Stambaugh (stambaughw)]

@Jeff, I just tried to cherry-pick this and it's intermingled with your
UI changes so it's got a lot of merge conflicts in the dialog code. If
you get chance please take a look at it and see if you can figure out
how to get this merged into the 5.0 branch. I may have a go at it again
tomorrow if I can find the time but it's not going to be trivial. It
might be best to merge everything but the dialog code (which does merge
cleanly) and update the 5.0 dialogs by hand.

On 08/24/2018 03:05 PM, Jeff Young wrote:
> @Wayne, I dunno. I certainly didn't have this bug in mind when I fixed
> the other one, but I can see where the fix could have handled both.
>
> I can't think of anything else that could impact this, but then again I
> had forgotten about the commit you did find, so take all that with a
> grain of salt....
>

[Jeff Young (jeyjey)]

I’ve completed the cherry-pick & merge. Building now….

[KiCad Janitor (kicad-janitor)]

Fixed in revision 7e2e39ce304d96be2935a4c664e7482bf3ffc5bb
https://git.launchpad.net/kicad/patch/?id=7e2e39ce304d96be2935a4c664e7482bf3ffc5bb

[Jeff Young (jeyjey)]

(Flagging as critical as the cache is overwritten.)