Footprint editor loses all the work without asking if you open another footprint from pcbnew

[Valerio Nappi]

This is the scenario i faced this evening:

I was working on a footprint in the footprint editor. I had some unsaved progresses.
I go into pcbnew to compare my work against some similar footprints. I try to measure a feature on the footprint but i realize that opening the footprint in the editor would have made my measurement much easier. So i go into footprint properties, click "Footprint editor" and it opens the new footprint in the editor, losing all the progress made with the one i was working with. Without even asking "There are some unsaved changes, do you want to discard them?"

This looks a pretty serious flaw to me. Because usually if you open another footprint it asks if the user wants to save the current footprint before.

I was able to reproduce this bug all the times.

Running on kicad 5.0.0, windows 10. Details:

Application: kicad
Version: (5.0.0), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

While I was tempted to mark this as Critical, it's actually been that way since 2010, so I settled on High.

It's a one-word change, so I'm adding it to 5.0.1 as well.

[Jeff Young (jeyjey)]

Turned out to be three lines to get the Footprint Editor to show before the warning dialog does, but it should still be safe enough for 5.0.1....

[KiCad Janitor (kicad-janitor)]

Fixed in revision a45a8e8797d66616a7dd1cd0e50349d7ec2e4871
https://git.launchpad.net/kicad/patch/?id=a45a8e8797d66616a7dd1cd0e50349d7ec2e4871

[Valerio Nappi (valerio.new)]

That was fast! Thank you!