incorect way of argument negation in _deploy_tripleo_heat_templates() function call

Bug #1786293 reported by Radoslaw Smigielski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Radoslaw Smigielski

Bug Description

Below assignment to "cleanup" variable inside the call of the function process_multiple_environments throws TyepError exception:

        env_files, localenv = utils.process_multiple_environments(
            created_env_files, tht_root, user_tht_root,
            cleanup=not parsed_args.no_cleanup)

As this can be seen below in PDB session:

> /usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py(498)_deploy_tripleo_heat_templates()
-> cleanup=not parsed_args.no_cleanup)
(Pdb) n
TypeError: TypeErro...atting',)

Changed in tripleo:
assignee: nobody → Radoslaw Smigielski (radoslaw-smigielski)
status: New → Incomplete
status: Incomplete → In Progress
Changed in tripleo:
milestone: none → rocky-rc1
importance: Undecided → Medium
Revision history for this message
Radoslaw Smigielski (radoslaw-smigielski) wrote :
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/590400
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=6fa2ca428eef2353836e79d66f2fec059ad34ca0
Submitter: Zuul
Branch: master

commit 6fa2ca428eef2353836e79d66f2fec059ad34ca0
Author: Radoslaw Smigielski <email address hidden>
Date: Thu Aug 9 17:20:21 2018 +0200

    Fix the way how we do argument negation

    The way we do "cleanup" variable negation causes TypeError exception.

    Change-Id: If24a5c48e845368e6040f41f8df9c87a11d858e3
    Closes-Bug: 1786293

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 11.0.0

This issue was fixed in the openstack/python-tripleoclient 11.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.