FFWD: boot_param_tasks.yaml doesn't set BOOTPROTO=none due to conditions are never met

[Sergii Golovatiuk]

Ansible stores the interface data, it transcribes the '-' to '_' so br-ex becomes ansible_br_ex. It's very easy to check that with 'ansible -i inv all -m setup' so

      - replace:
          dest: "{{ item.path }}"
          regexp: '^BOOTPROTO=.*'
          replace: 'BOOTPROTO=none'
        when:

is never executed as when conditions are never met.

Expected result
===============
See 'BOOTPROTO=none' in /etc/sysconfig/network-scripts/ for all active interfaces except lo

Actual result
=============
BOOTPROTO was not changed as conditions were never met.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/590208

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/590208
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6ab5112eb207cd2f87956f1c574d0b70236ef2e3
Submitter: Zuul
Branch: master

commit 6ab5112eb207cd2f87956f1c574d0b70236ef2e3
Author: Sergii Golovatiuk <email address hidden>
Date: Thu Aug 9 12:13:46 2018 +0300

    Fix interfaces in boot_param_tasks

    Ansible stores all interfaces with _ in facts. It's very easy to check by
    running 'ansible -i inv all -m setup'. This patch adds replace - with _ to find
    interface properly in facts.

    Change-Id: Id290143d8a41964806ca9c5be4d7103a3833cb37
    Closes-Bug: #1786212

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/600374

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600374
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c68f853204186feeca748432a332c402aa4aeeb8
Submitter: Zuul
Branch: stable/queens

commit c68f853204186feeca748432a332c402aa4aeeb8
Author: Sergii Golovatiuk <email address hidden>
Date: Thu Aug 9 12:13:46 2018 +0300

    Fix interfaces in boot_param_tasks

    Ansible stores all interfaces with _ in facts. It's very easy to check by
    running 'ansible -i inv all -m setup'. This patch adds replace - with _ to find
    interface properly in facts.

    Closes-Bug: #1786212
    Resolves: rhbz#1614036

    Change-Id: Id290143d8a41964806ca9c5be4d7103a3833cb37
    (cherry picked from commit 6ab5112eb207cd2f87956f1c574d0b70236ef2e3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.6 release.