Containers image prepare fails if cant generate the output file

Bug #1786204 reported by Carlos Camacho
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Alex Schultz

Bug Description

If the folders for /home/stack/virt/docker-images.yaml does not exist or if the folder has no privileges the image prepare command fails with:

    (undercloud) [stack@undercloud-0 ~]$ openstack overcloud container image prepare \
    > --env-file=/home/stack/virt/docker-images.yaml \
    > --prefix=openstack- \
    > --tag="$TAG" \
    > --set ceph_image="$CEPH_IMAGE" \
    > --set ceph_tag="$CEPH_TAG" \
    > --environment-file=/usr/share/openstack-tripleo-heat-templates/environments/services/sahara.yaml \
    > --environment-file=/usr/share/openstack-tripleo-heat-templates/environments/storage-environment.yaml \
    > --namespace=$REGISTRY/rhosp13 \
    > --set ceph_namespace=$CEPH_NAMESPACE

    [Errno 2] No such file or directory: '/home/stack/virt/docker-images.yaml'

We need to fail correctly if we are unable to create the file.

Malformed --output-env-file=(/home/stack/virt/virt/docker-images.yaml). The output file can not be created

Changed in tripleo:
importance: Undecided → Medium
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Carlos Camacho (ccamacho) wrote :
description: updated
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Changed in tripleo:
assignee: Carlos Camacho (ccamacho) → Alex Schultz (alex-schultz)
Changed in tripleo:
milestone: stein-1 → stein-2
Changed in tripleo:
milestone: stein-2 → stein-3
Changed in tripleo:
milestone: stein-3 → train-1
Changed in tripleo:
milestone: train-1 → train-2
Changed in tripleo:
milestone: train-2 → train-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/587405
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0521f0a5d728a6f16eaaf9c929b6f2e3999c5dc7
Submitter: Zuul
Branch: master

commit 0521f0a5d728a6f16eaaf9c929b6f2e3999c5dc7
Author: Carlos Camacho <email address hidden>
Date: Tue Jul 31 06:32:36 2018 -0400

    Fail correctly if can't create output files

    This patch makes the containers image prepare
    command fails correctly if the output file can't be
    created properly.

    Closes-Bug: 1786204
    Change-Id: I7187a521f850050c2bc30fee4f86284e5c6ec05d
    Co-Authored-By: Alex Schultz <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.2.0

This issue was fixed in the openstack/python-tripleoclient 12.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.