Containers image prepare fails if cant generate the output file

[Carlos Camacho]

If the folders for /home/stack/virt/docker-images.yaml does not exist or if the folder has no privileges the image prepare command fails with:

    (undercloud) [stack@undercloud-0 ~]$ openstack overcloud container image prepare \
    > --env-file=/home/stack/virt/docker-images.yaml \
    > --prefix=openstack- \
    > --tag="$TAG" \
    > --set ceph_image="$CEPH_IMAGE" \
    > --set ceph_tag="$CEPH_TAG" \
    > --environment-file=/usr/share/openstack-tripleo-heat-templates/environments/services/sahara.yaml \
    > --environment-file=/usr/share/openstack-tripleo-heat-templates/environments/storage-environment.yaml \
    > --namespace=$REGISTRY/rhosp13 \
    > --set ceph_namespace=$CEPH_NAMESPACE

    [Errno 2] No such file or directory: '/home/stack/virt/docker-images.yaml'

We need to fail correctly if we are unable to create the file.

Malformed --output-env-file=(/home/stack/virt/virt/docker-images.yaml). The output file can not be created

[Carlos Camacho (ccamacho)]

Fix proposed: https://review.openstack.org/#/c/587405

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/587405
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0521f0a5d728a6f16eaaf9c929b6f2e3999c5dc7
Submitter: Zuul
Branch: master

commit 0521f0a5d728a6f16eaaf9c929b6f2e3999c5dc7
Author: Carlos Camacho <email address hidden>
Date: Tue Jul 31 06:32:36 2018 -0400

    Fail correctly if can't create output files

    This patch makes the containers image prepare
    command fails correctly if the output file can't be
    created properly.

    Closes-Bug: 1786204
    Change-Id: I7187a521f850050c2bc30fee4f86284e5c6ec05d
    Co-Authored-By: Alex Schultz <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.2.0 release.