Please merge mpv 0.29 from Debian

[Daniel van Vugt]

Please merge mpv 0.29 from Debian

https://packages.debian.org/unstable/mpv

[Simon Quigley (tsimonq2)]

Please explain why the delta can be dropped.

[Daniel van Vugt (vanvugt)]

Oh. It probably can't. I forgot about my own patches...

[Doug McMahon (mc3man)]

The hwdec patch will still be ok for xserver but not suitable for wayland as vaapi in wayland needs more specific command(s).

[Daniel van Vugt (vanvugt)]

It looks like I just need to rewrite 08_fix-lp1698287.patch to fix the Wayland case..? Same old bug 1698287.

[Daniel van Vugt (vanvugt)]

There's a new dependency on ffmpeg 4.0, but we have that in cosmic-proposed already.

[Doug McMahon (mc3man)]

This is what I've found concerning wayland, vappi & current mpv (-- is for cli use only

--hwdec= or --hwdec=yes or --hwdec=auto # hwdec using vaapi-copy w/ deco, terminal warnings, error lines

--gpu-context=x11egl --hwdec=vaapi-copy # hwdec w/ deco, no terminal warnings, errors

--gpu-context=wayland --hwdec=vaapi-copy # hwdec using vaapi-copy w/ no deco

--gpu-context=wayland --hwdec=vaapi # hwdec using vaapi w/ no deco

So only the last one vaapi & that option set is not compatible with X

[Doug McMahon (mc3man)]

To note:
the current hwdec=vaapi will not use any hwdec in wayland.
A generic for both X & wayland could be this, produces vaapi-copy in wayland, vaapi in X
( though non specifeied hwdec will affect nvidia & amd prop drivers..

gpu-context=x11egl
hwdec=

[Daniel van Vugt (vanvugt)]

Doug, I think you are incorrect (at least incorrect mentioning that here).

I fixed VAAPI support on Wayland yesterday in a patch inside version 0.29.0-1ubuntu1 above.

[Simon Quigley (tsimonq2)]

Instead of attaching the dsc file, etc. please attach a debdiff between the version currently in Cosmic and the version you have.

Unsubscribing sponsors for now.

[Daniel van Vugt (vanvugt)]

That's inappropriate for significant version upgrades, which this is. We usually handle large upgrades without using debdiffs.

[Daniel van Vugt (vanvugt)]

The debdiff is 4.5MB. Here it is. But I don't think it's the right way to handle major upgrades like this.

[Simon Quigley (tsimonq2)]

> That's inappropriate for significant version upgrades, which this is.

I disagree. That's a standard which I uphold, and others do as well.

But, reviewing. Thanks.

[Daniel van Vugt (vanvugt)]

BTW the diff to be reviewing really is against Debian version 0.29.0-1, not the previous Ubuntu version. This is a "rebase" on the latest Debian version.

[Daniel van Vugt (vanvugt)]

Here's the (tiny) diff from Debian. A bit easier to read :)

[Daniel van Vugt (vanvugt)]

Now in cosmic-proposed. Thanks Simon, or whoever did that.

Though it's going to be stuck in proposed until ffmpeg >= 4.0 reaches cosmic release.

[Daniel van Vugt (vanvugt)]

mpv (0.29.0-1ubuntu1) cosmic; urgency=medium

  * Rewrote 08_fix-lp1698287.patch to work with the latest mpv source code,
    allowing VAAPI to work in Wayland sessions out-of-the-box. (LP: #1698287)
  * Reintroduce mpv.conf.ubuntu to enable VAAPI acceleration by default.
    (LP: #1708102)
  * Rebased on latest Debian version 0.29.0-1.

 -- Daniel van Vugt <email address hidden> Thu, 09 Aug 2018 18:04:13 +0800