Obsolete --container-registry-file is still present in update/upgrade CLI

[Jiří Stránský]

We use normal environment file to provide container registry, no need to have a special parameter.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/589487

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/571186
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c837491161c24ca7bb9fbfcbb3b51d88c8d7b9d1
Submitter: Zuul
Branch: master

commit c837491161c24ca7bb9fbfcbb3b51d88c8d7b9d1
Author: mandreou <email address hidden>
Date: Wed May 30 15:06:55 2018 +0300

    Remove container_registry param from package update action

    The package_update_plan mistrl workflow is invoked in upgrade|update|
    ceph-upgrade|ffwd-upgrade prepare clis. The container registry
    parameter is being removed and we will use treat it as a regular
    environment file (see depends-on). This removes it from the Mistral
    action and keeps it defaulted in the workflow to prevent
    chicken-and-egg issues with CI. We'll remove the workflow parameter in
    a follow-up patch.

    Partial-Bug: #1785825
    Co-Authored-By: Jiri Stransky <email address hidden>
    Related: https://review.openstack.org/570893 python-tripleoclient
    Change-Id: I4130dd1eea6caec82dcb4a699875f2951693148f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/570893
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ac44a859378f28c017c918f7bfa318eb23acc99a
Submitter: Zuul
Branch: master

commit ac44a859378f28c017c918f7bfa318eb23acc99a
Author: mandreou <email address hidden>
Date: Tue May 29 13:03:17 2018 +0300

    Remove --container-registry-file parameter from * upgrade clis

    Currently the container image registry references are passed with
    --container-registry-file in prepare but as -e in converge for
    the upgrade/update/ffwd-upgrade/ceph-upgrade clis.

    There is no special handling of the file, and it is ultimately
    included as any other environment file [1].

    This removes the --container-registry-file parameter from
    openstack overcloud [upgrade|update|ffwd-upgrade|ceph-upgrade]
    prepare.

    The related tripleo-common review is for removal of the parameter
    from the mistral workflow and action

    The related tripleo-docs patch is for updating the operator
    instructions to include the container image registry references
    using -e as any other environment file.

    [1] https://github.com/openstack/tripleo-common/blob/2c83dc964bc3a00504d580cbad8eb54f45fad8bf/tripleo_common/actions/package_update.py#L60
    Related: https://review.openstack.org/570903 tripleo-docs
    Partial-Bug: #1785825
    Co-Authored-By: Jiri Stransky <email address hidden>
    Depends-On: https://review.openstack.org/571186
    Change-Id: Id2811dbef59d1be2a35cea062eb7116648f52145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/589487
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=68b53034e0b0dd9b1881475ede26fac8e474e13f
Submitter: Zuul
Branch: master

commit 68b53034e0b0dd9b1881475ede26fac8e474e13f
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 7 15:51:05 2018 +0200

    Remove container_registry parameter from update workflows

    After Id2811dbef59d1be2a35cea062eb7116648f52145 removed the parameter
    from client, it can be fully removed from the workflow too.

    Closes-Bug: #1785825
    Change-Id: Ieb0e4fc7f05ba9bcae870fa9a5030977cd71a92d
    Depends-On: Id2811dbef59d1be2a35cea062eb7116648f52145

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.3.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/599348

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/599349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/599349
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0279666fb75319c608b8b2a26292b272f57b0703
Submitter: Zuul
Branch: stable/queens

commit 0279666fb75319c608b8b2a26292b272f57b0703
Author: mandreou <email address hidden>
Date: Tue May 29 13:03:17 2018 +0300

    Remove --container-registry-file parameter from * upgrade clis

    Currently the container image registry references are passed with
    --container-registry-file in prepare but as -e in converge for
    the upgrade/update/ffwd-upgrade/ceph-upgrade clis.

    There is no special handling of the file, and it is ultimately
    included as any other environment file [1].

    This removes the --container-registry-file parameter from
    openstack overcloud [upgrade|update|ffwd-upgrade|ceph-upgrade]
    prepare.

    The related tripleo-common review is for removal of the parameter
    from the mistral workflow and action

    The related tripleo-docs patch is for updating the operator
    instructions to include the container image registry references
    using -e as any other environment file.

    [1] https://github.com/openstack/tripleo-common/blob/2c83dc964bc3a00504d580cbad8eb54f45fad8bf/tripleo_common/actions/package_update.py#L60
    Related: https://review.openstack.org/570903 tripleo-docs
    Partial-Bug: #1785825
    Co-Authored-By: Jiri Stransky <email address hidden>
    Depends-On: https://review.openstack.org/571186
    Change-Id: Id2811dbef59d1be2a35cea062eb7116648f52145
    (cherry picked from commit ac44a859378f28c017c918f7bfa318eb23acc99a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/599348
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=40d4c37bf21dbece595e04ffb8ddefcbfe250a65
Submitter: Zuul
Branch: stable/queens

commit 40d4c37bf21dbece595e04ffb8ddefcbfe250a65
Author: mandreou <email address hidden>
Date: Wed May 30 15:06:55 2018 +0300

    Remove container_registry param from package update action

    The package_update_plan mistrl workflow is invoked in upgrade|update|
    ceph-upgrade|ffwd-upgrade prepare clis. The container registry
    parameter is being removed and we will use treat it as a regular
    environment file (see depends-on). This removes it from the Mistral
    action and keeps it defaulted in the workflow to prevent
    chicken-and-egg issues with CI. We'll remove the workflow parameter in
    a follow-up patch.

    Partial-Bug: #1785825
    Co-Authored-By: Jiri Stransky <email address hidden>
    Related: https://review.openstack.org/570893 python-tripleoclient
    Change-Id: I4130dd1eea6caec82dcb4a699875f2951693148f
    (cherry picked from commit c837491161c24ca7bb9fbfcbb3b51d88c8d7b9d1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/601630

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/601630
Reason: Purging the gate to free up resources and address the timeout issues

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/601630
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=62711e0c4fed1ba3f232988ffd9435ecad7827c3
Submitter: Zuul
Branch: stable/queens

commit 62711e0c4fed1ba3f232988ffd9435ecad7827c3
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 7 15:51:05 2018 +0200

    Remove container_registry parameter from update workflows

    After Id2811dbef59d1be2a35cea062eb7116648f52145 removed the parameter
    from client, it can be fully removed from the workflow too.

    Closes-Bug: #1785825
    Change-Id: Ieb0e4fc7f05ba9bcae870fa9a5030977cd71a92d
    Depends-On: Id2811dbef59d1be2a35cea062eb7116648f52145
    (cherry picked from commit 68b53034e0b0dd9b1881475ede26fac8e474e13f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.6.7 release.