Mobile "Filters Applied" count misleading

[Suzanne Paterno]

When viewing OPAC on a mobile device, a "Filters Applied" count appears below the search button after performing a search even when the user does not have any filters selected. When this link is clicked on nothing happens.

The "filters" it believes it has applied are "skip_check" and "check_limit". Any sorting ("sort") including poprel is also counted as a filter.

Going through search logs I was unable to find different values of skip_check(0) or check_limit(1000) in search strings. I tried multiple OPAC searches with various use settings, from different catalog pages (results, home, my account), etc. to get these values to change, but none did.

"Filters" users cannot change or modify should not be counting as "filters applied" to mobile users.

This can be fixed by adding "skip_check", "check_limit" and possibly "sort to the list of ignorable filters in searchbar.tt2

I've made the changes on our system and will be pushing them to git working branch.

[Benjamin Kalish (bkalish)]

Clicking the link does do one think. It causes a Javascript error. If you have the console open you will see something like the following:

Uncaught TypeError: Cannot read properties of null (reading 'classList')
    at getAdvLimits (results?query=lost+and+found&qtype=keyword&fi%3Asearch_format=&locg=247&detail_record_view=0&sort=poprel:2153:81)
    at HTMLAnchorElement.onclick (results?query=lost+and+found&qtype=keyword&fi%3Asearch_format=&locg=247&detail_record_view=0&sort=poprel:2141:85)
getAdvLimits @ results?query=lost+and+found&qtype=keyword&fi%3Asearch_format=&locg=247&detail_record_view=0&sort=poprel:2153
onclick @ results?query=lost+and+found&qtype=keyword&fi%3Asearch_format=&locg=247&detail_record_view=0&sort=poprel:2141

[Andrea Neiman (aneiman)]

Confirmed still a thing in BOOPAC 3.12.

Tested on Chrome 123.0.6312.40 on Android 14.