API succeeds if invalid parameter is passed

[Andres Rodriguez]

I passed an invalid parameter over the API and it succeeded without showing me an error.

In this case, the resource_pool parameter doesn't exist, but the operation succeeded.

ubuntu@maas00:~$ maas admin machine update k8s4kq resource_pool=test-pool
Success.
Machine-readable output follows:
{
    "volume_groups": [],
    "cpu_speed": 2300,
    "storage": 120034.123776,
    "status_message": "",
    "zone": {
        "name": "test1",
        "description": "",
        "id": 1,
        "resource_uri": "/MAAS/api/2.0/zones/test1/"
    },
    "tag_names": [],
    "status_action": "",

[Mike Pontillo (mpontillo)]

This is a large API design change that would need to be discussed further before implementing.

Each API endpoint differs in how it accepts parameters (some are tightly coupled to Django forms, and some aren't, for example).

Implementing it generally may also cause forward-compatibility problems (such as if we support a new optional parameter in MAAS 2.6, and API clients make use of it before it is available).

Finally, this is a risky change to treat as a bug fix, since it would touch the entire surface of the API.

Thus, marking this 'Opinion' until we discuss further.

[Jerzy Husakowski (jhusakowski)]

CLI improvement request moved to internal backlog for further prioritisation (Internal ref. PF-3912)