Webstaff Copy Patron Address to Clipboard

Bug #1785681 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.0
Won't Fix
Low
Unassigned
3.1
Fix Released
Low
Unassigned

Bug Description

Evergreen 3.1

In the browser client patron summary pane along the left of the main patron interface (search, checkout, etc.), the option to print the patron address is available, but unlike the XUL client, there is no option to copy the address to the clipboard.

While you can copy/paste much easier in the browser client, copying the address along with the patron's name would require a number clicks. The XUL feature should be brought over to the browser client.

Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Bill Erickson (berick) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.1.5
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Garry Collum (gcollum) wrote :

Tested in Chrome and Firefox. Works perfectly. The patron's name and address are copied to the clipboard. A signed-off branch is at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1785681-copy-patron-address-signoff

tags: added: signedoff
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I had a look at this and noticed a difference in behavior between the copy and print links. The copy link puts the name in LAST NAME, FIRST NAME format and print does FIRST NAME LAST NAME. Shouldn't they be the same? If so, I'd suggest the print behavior for both.

Revision history for this message
Bill Erickson (berick) wrote :

Arg, yes, that was the intention. Thanks, Jason. Fixing now.

Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1785681-copy-patron-address-signoff

I took the liberty of squashing it into the signed off commit since it was a minor change.

Revision history for this message
Garry Collum (gcollum) wrote :

Good catch Jason.

Changed in evergreen:
milestone: 3.1.5 → 3.1.6
Changed in evergreen:
milestone: 3.1.6 → 3.1.7
milestone: 3.1.7 → 3.2.1
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_2, and rel_3_1. Thanks, Bill, Garry, and Jason!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.