not all params honored in deploy-steps-tasks.yaml with config-download

[James Slagle]

the same list of vars wasn't getting passed to config-download when deploy-steps-tasks.yaml runs as with the non-config-download method.

The list is:

update_identifier: {get_param: DeployIdentifier}
enable_debug: {get_param: ConfigDebug}
enable_puppet: {get_param: EnablePuppet}
docker_puppet_debug: {get_param: DockerPuppetDebug}
docker_puppet_process_count: {get_param: DockerPuppetProcessCount}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/589173

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/589173
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=553fc0d26414cfda1faa3e19eb06d79913ef8a29
Submitter: Zuul
Branch: master

commit 553fc0d26414cfda1faa3e19eb06d79913ef8a29
Author: James Slagle <email address hidden>
Date: Mon Aug 6 10:15:56 2018 -0400

    Pass all vars to deploy-steps-tasks.yaml with config-download

    Not all vars were getting passed to deploy-steps-tasks.yaml when using
    config-download. This didn't cause any issue because all the vars have
    default value, but the user specified value should be honored as well.

    Change-Id: I5972e1c674cf9008366c2bb10b54eb975ab8cb93
    Closes-Bug: #1785635

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/597055

[Bogdan Dobrelya (bogdando)]

It seems it has yet been fully fixed, see how https://review.openstack.org/#/c/612948 fails with undefined enable_puppet, still, once I removed the |default() fallback for it

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/613306

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613306
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5a5ad11d0b61ee81e536864a22d515b041bc8891
Submitter: Zuul
Branch: master

commit 5a5ad11d0b61ee81e536864a22d515b041bc8891
Author: James Slagle <email address hidden>
Date: Thu Oct 25 08:26:16 2018 -0400

    Add common vars to common plays

    We should pass in the common vars to all the common plays in
    deploy-steps.j2 so that tasks will have them available. Some of these
    parameter driven variables were never actually wired up, so they didn't
    work to begin with (such as enable_puppet/enable_debug).

    Change-Id: I830e1ae21fe3e278a5f7591065d066c0a6883a9a
    Closes-Bug: #1785635

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/597055
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=221a9eb5d98bdd1423e7847eaa958eab2c87a25f
Submitter: Zuul
Branch: stable/queens

commit 221a9eb5d98bdd1423e7847eaa958eab2c87a25f
Author: James Slagle <email address hidden>
Date: Mon Aug 6 10:15:56 2018 -0400

    Pass all vars to deploy-steps-tasks.yaml with config-download

    Not all vars were getting passed to deploy-steps-tasks.yaml when using
    config-download. This didn't cause any issue because all the vars have
    default value, but the user specified value should be honored as well.

    Change-Id: I5972e1c674cf9008366c2bb10b54eb975ab8cb93
    Closes-Bug: #1785635
    (cherry picked from commit 553fc0d26414cfda1faa3e19eb06d79913ef8a29)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.