When working with python3 header banner is not rendered properly

[Yuval Adar]

When running horizon under python 3, the header banner response returned is in bytes format, and python 3 interprets it different from python 2, thus breaking the banner completely

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/589121

[Akihiro Motoki (amotoki)]

What is "header banner response" you mean?

I installed libapache2-mod-wsgi-py3 to run horizon with python3, but it seems everything works fine.
Could you elaborate more?

[Yuval Adar (yadar)]

When rendering the web page you have the header and the main body sections. In the header, you can display a custom banner. When you have Vitrage (RCA project) enabled, the header will display Vitrage banner.
This is rendered using request.render() from Django

When everything works with python2, request.render() returns byte encoded response, and python2.7 ignores is and treats is like plain text string. Python3 doesn't ignore it, and it breaks

This patch reformats the response for python3 and python2 and the banner will render properly

See posted screenshots for more details

[Yuval Adar (yadar)]

same one rendered on python 2.7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/589121
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f7eefaa9937f2fc1e05caee65334cdd0d93159c9
Submitter: Zuul
Branch: master

commit f7eefaa9937f2fc1e05caee65334cdd0d93159c9
Author: Yuval Adar <email address hidden>
Date: Mon Aug 6 14:14:24 2018 +0300

    force plain text for header response

    Change-Id: I239a1ccc530ce652cc2165eef38b9f8193769102
    Closes-Bug: #1785606