Web Client: Right Clicking a Selection of Highlighted Rows in a Grid Clears the Selection

[John Amundson]

I have only observed this in Evergreen 3.0.10. This is not a problem in Evergreen 3.0.8.
Tested in Google Chrome. Have not tested yet in Firefox.

I'm wondering if this bug is side effect of the fix for bug 1776557 | bug 1669856.

In many interfaces in the web client in 3.0.10, if you select multiple rows, (either by individually selecting or highlighting via shift clicking), and right click a highlighted row to bring up the Actions menu, all rows save for the one you right-clicked become unselected. It was my understanding that the highlighted rows should only be cleared if you right-click an unselected row.

This only happens on grids that are not "built on the fly". For example, Item Status, Check In, etc all behave as they should and maintain the highlighted rows on a right-click. However, most other interfaces, (i.e. View Holds, Items Out, Bills, Transit List, etc), all seem to be affected by this bug.

On a somewhat funny side note, if you can manage to right-click on one of the lines between the rows, the items will all stay highlighted and the Actions menu will appear.

[John Amundson (jamundson)]

Same behavior observed in Firefox

[a. bellenir (abellenir)]

good catch.

> I'm wondering if this bug is side effect of the fix for bug 1776557 | bug 1669856.

yes, definitely. the 1776557/1669856 fix was based on some assumptions that turn out to only be true for dynamic "on the fly" grids like item status. this made it always think the row you right-clicked on in a static list was deselected.

i believe the problem to be fixed in this branch: lp1785333-right-click-clears-selection (http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1785333-right-click-clears-selection)

[John Amundson (jamundson)]

I tested and confirmed this patch remedies the issue of this bug while maintaining the fixes from bug 1776557 | bug 1669856

I tested on both types of grids, (Item Status and Bills, Current to be exact).

- Right clicking on a link will bring up the browser's context menu regardless of which row is highlighted.(bug 1669856)
- Right clicking off your selected row(s) deselects the rows and brings up the actions menu for the right-clicked row. (bug 1776557)
- Right clicking a highlighted selection of rows maintains the selection and opens the actions menu. (this bug)

Thank you for your work on this, abellenir

I have tested this code and consent to signing off on it with my name, John Amundson and my email address, <email address hidden>.

[Mike Rylander (mrylander)]

Thanks, John and a. I squashed the commits, updated the commit message, and picked that to master, 3.1 and 3.0.