upgrade-non-controller.sh needs to use the stack name

[Carlos Camacho]

We are using upgrade-non-controller.sh without specifying the stack name.

So, all calls will fail if the Overcloud stack name is different than overcloud.

Example of this issue:

Description of problem:
-----------------------
Upgrade of compute nodes in overcloud called qe-Cloud-0 failed:

source /home/stack/stackrc
upgrade-non-controller.sh --upgrade cmp-0-r1 &> cmp-0-r1-upgrade.log

Thu Aug 2 04:35:03 EDT 2018 upgrade-non-controller.sh Logging to upgrade-non-controller.sh-cmp-0-r1
Thu Aug 2 04:35:09 EDT 2018 upgrade-non-controller.sh nova node cmp-0-r1 found with IP 192.168.24.14
Thu Aug 2 04:35:09 EDT 2018 upgrade-non-controller.sh Executing /root/tripleo_upgrade_node.sh on 192.168.24.14
Warning: Permanently added '192.168.24.14' (ECDSA) to the list of known hosts.
 "nova_compute",
Thu Aug 2 08:35:09 UTC 2018 082ee803-43af-4d8e-a04c-43d5a2d48a6b tripleo-upgrade cmp-0-r1 /root/tripleo_upgrade_node.sh has completed - moving onto ansible playbooks
Thu Aug 2 04:35:10 EDT 2018 upgrade-non-controller.sh Clearing any existing dir cmp-0-r1 and downloading config
ERROR: The Stack (overcloud) could not be found.

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
python-tripleoclient-7.3.10-3.el7ost.noarch
openstack-tripleo-heat-templates-7.0.12-5.el7ost.noarch

Steps to Reproduce:
-------------------
1. Deploy RHOS-11 with custom stack name
2. Follow upgrade procedure to upgrade to RHOS-12

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/588202

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/588203

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/588231

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carlos Camacho (<email address hidden>) on branch: master
Review: https://review.openstack.org/588203
Reason: Using https://review.openstack.org/#/c/588231

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/588241

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/588202
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=db03475b49e42f449b8eeb1478314f202d845f79
Submitter: Zuul
Branch: master

commit db03475b49e42f449b8eeb1478314f202d845f79
Author: Carlos Camacho <email address hidden>
Date: Thu Aug 2 12:17:16 2018 +0200

    Add the overcloud stack name when calling upgrade-non-controller.sh

    If we call upgrade-non-controller.sh we might need to use a different stack
    name.

    This patch adds the Overcloud stack name when calling upgrade-non-controller.sh

    Change-Id: I2e8ac84033521a992f6c36571ea8054522f8871c
    Partial-bug: 1785040

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/588450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/588489

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/588506

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/588450
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=5dc0496aaeb45d54ab4bd4462264ac3298f1ec80
Submitter: Zuul
Branch: stable/pike

commit 5dc0496aaeb45d54ab4bd4462264ac3298f1ec80
Author: Carlos Camacho <email address hidden>
Date: Thu Aug 2 12:17:16 2018 +0200

    Add the overcloud stack name when calling upgrade-non-controller.sh

    If we call upgrade-non-controller.sh we might need to use a different stack
    name.

    This patch adds the Overcloud stack name when calling upgrade-non-controller.sh

    Change-Id: I2e8ac84033521a992f6c36571ea8054522f8871c
    Partial-bug: 1785040
    (cherry picked from commit db03475b49e42f449b8eeb1478314f202d845f79)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carlos Camacho (<email address hidden>) on branch: master
Review: https://review.openstack.org/588231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/588489
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=878e5376d3a72afb851108a92c50dfa9c15ee6f8
Submitter: Zuul
Branch: stable/queens

commit 878e5376d3a72afb851108a92c50dfa9c15ee6f8
Author: Carlos Camacho <email address hidden>
Date: Fri Aug 3 11:37:27 2018 +0200

    Include the stack name when generating the tripleo-ansible-inventory

    The stack name is not included when
    generating the tripleo-ansible-inventory
    this patch adds this option.

    Change-Id: Ie19f4ffad0f652a1d5f519b8976181e7d3c7c18a
    Partial-bug: 1785040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/588506
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7a136d8fb2a4dd6766ede5927e2c85aa22ce8c84
Submitter: Zuul
Branch: stable/pike

commit 7a136d8fb2a4dd6766ede5927e2c85aa22ce8c84
Author: Carlos Camacho <email address hidden>
Date: Fri Aug 3 11:37:27 2018 +0200

    Include the stack name when generating the tripleo-ansible-inventory

    The stack name is not included when
    generating the tripleo-ansible-inventory
    this patch adds this option.

    Change-Id: Ie19f4ffad0f652a1d5f519b8976181e7d3c7c18a
    Partial-bug: 1785040
    (cherrypicked from commit 878e5376d3a72afb851108a92c50dfa9c15ee6f8)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carlos Camacho (<email address hidden>) on branch: master
Review: https://review.opendev.org/588241