Unable to retrieve offline patron registration form

[Kathy Lussier]

Evergreen version: master, as of 7/31/18

I continue to have trouble retrieving the offline patron registration interface, as previously described in bug 1755220. I am able to retrieve it on the MassLNC community demo server, which was updated with 3.1.4 last week, but I can't retrieve it on a VM running a clean install of master with no additional customizations or branches.

I see the following in the Console when I first retrieve the offline interface in master:

vendor.bundle.js:6 ReferenceError: q is not defined
    at offline.js:851
    at Array.filter (<anonymous>)
    at offline.js:850
    at Object.o [as forEach] (vendor.bundle.js:6)
    at offline.js:849
    at u (vendor.bundle.js:6)
    at vendor.bundle.js:6
    at h.$digest (vendor.bundle.js:6)
    at vendor.bundle.js:6
    at r (vendor.bundle.js:6) "Possibly unhandled rejection: {}"

There are some other errors that show in the Console, but those also appear on the 3.1.4 system that is behaving as expected.

When I click the tab to register a patron, the progress bar hangs, and the form never appears.

[Bill Erickson (berick)]

This got in my way working on bug #1775719. I pushed a fix to that branch, then forgot about it. The fix is trivial if this bug needs to be repaired first:

@@ -847,7 +841,7 @@ function($routeProvider , $locationProvider , $compileProvider) {
                         return egLovefield.reconstituteList('asva');
                     }).then(function() {
                         angular.forEach(egCore.env.asv.list, function (s) {
- s.questions( egCore.env.asva.list.filter( function (a) {
+ s.questions( egCore.env.asvq.list.filter( function (q) {

[Kathy Lussier (klussier)]

I was planning to look at bug 1775719 this week, so I think we can wait for that branch to go in. I'll mark this one as a duplicate.

Thanks Bill!