macOS: Secondary language loaded as default

[Toni Förster]

I was able to reproduce this on macOS 10.13.6 with build_19 and nightly r8771.

I have three languages as my preferred languages:

1. English (English) - set as primary
2. German (Germany)
3. Japanese

Widelands is set to:

selected language: (system language)

When I start Widelands from the Appbundle it uses German as default language. When I remove German from the preferred languages in the macOS System Preferences, Widelands uses Japanese, since this is the new secondary language.

To make Widelands recognize English as the system language, I either have to start it from the Terminal with:

open Widelands.app

or I have to remove the secondary and tertiary language from the System Preferences.

[GunChleoc (gunchleoc)]

@Klaus: Do you still have a Mac?

[Klaus Halfmann (klaus-halfmann)]

Ill check for this one, yes I own and build on mac.
Hope I can get mack from Japanese to German or English :-)

[Klaus Halfmann (klaus-halfmann)]

Was able to reproduce this on bzr8773[trunk] starting it from ther Terminal directly.
(The default build does make this an App ....) using open actual does this via the Terminal.
useing ope o R19 stillw as in German, well.

Second part of the Bug as well.
I assume its some odd 0/1 confusion.

Will check this with a debugger.

[Klaus Halfmann (klaus-halfmann)]

Mhh, even bzr does not like these locale settings:

$ locale
LANG=
LC_COLLATE="C"
LC_CTYPE="UTF-8"
LC_MESSAGES="C"
LC_MONETARY="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_ALL=

After switching back to German as default I got:
$ locale
LANG="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_CTYPE="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_ALL=

Maybe widelands has a similar Problem

[Klaus Halfmann (klaus-halfmann)]

The code is located in src/base/i18n.cc
I am setting up a branch "odd_locale_fix" to check this

[Klaus Halfmann (klaus-halfmann)]

I will provide a final fallback to "en" as a last option,

Maybe this is evene a Bug with Apple: https://bugreport.apple.com/web/?problemID=43183164

[Klaus Halfmann (klaus-halfmann)]

Got a branch thats fixes this issue for me.

[Klaus Halfmann (klaus-halfmann)]

Was merged to trunk for R20,
Toni: Welcome as widelands developer.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1