UI annoyance: select all cancels dialogs

[Stefan Bethge]

This might only happen on OSX but is quite annoying: when editing a text field in any dialog, pressing apple-a (which usually selects all) cancels the dialog and all changes are lost.
I guess the escape key would be fine as the sole replacement, it already closes the dialog fine.

[Stefan Bethge (kjyv)]

Application: kicad
Version: (5.0.0-3-g5ebb6b6), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.51.0
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

I can't reproduce this. Which dialog in particular? (And what language are you running?)

[Stefan Bethge (kjyv)]

Actually, it seems to be every dialog that has a cancel button. E.g. edit a symbol in Eeschema. You're right that it is probably language related as in german cancel is "Abbrechen". I'm not sure if in general, alt- or apple-(letter) is ever used to execute buttons in OS X like this so I think it would be fine to completely disable this shortcut on OS X. If not, it could possibly be ctrl-a and similar to prevent confusion.

[Jeff Young (jeyjey)]

Yeah, we had a similar bug on English systems where a copy (cmd-C) would do a Cancel. The reason is that wxWidgets has an ugly hack for MSW which intercepts the first-letter command keys before we even see them.

I should be able to generalize our hack to fix this to non-English systems....

[KiCad Janitor (kicad-janitor)]

Fixed in revision 98849bde9695a51556e0c4fe73c20eaac547db0d
https://git.launchpad.net/kicad/patch/?id=98849bde9695a51556e0c4fe73c20eaac547db0d

[Maciej Suminski (orsonmmz)]

Hi Jeff, I suppose this also applies to 5.0 branch?

[Jeff Young (jeyjey)]

@Orson, yep, I submitted it there too.

[Maciej Suminski (orsonmmz)]

Have you also pushed the changes? I cannot find the patch in the 5.0 branch [1].

1. https://code.launchpad.net/~kicad-product-committers/kicad/+git/product-git/+ref/5.0

[Jeff Young (jeyjey)]

D'oh. Pushed now.

[Maciej Suminski (orsonmmz)]

Everything is fine now, thanks!