"Disable Highlighting" box should be sticky

Bug #1783408 reported by Dale Rigney
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Wishlist
Unassigned

Bug Description

Wishlist:

Make the "Disable Highlighting" check box a "sticky" option. Currently there is option in the config.tt2 to remove the search highlighting altogether but if we made the box a sticky options people can then choose to disable the search highlighting feature until they want to use that option again.

Elaine Hardy (ehardy)
Changed in evergreen:
status: New → Confirmed
tags: added: usability
Changed in evergreen:
importance: Undecided → Wishlist
Revision history for this message
John Amundson (jamundson) wrote :
Revision history for this message
Terran McCanna (tmccanna) wrote :

See also for Angular staff catalog - https://bugs.launchpad.net/evergreen/+bug/1970946

tags: added: opac
Steven Mayo (stmayo)
Changed in evergreen:
assignee: nobody → Steven Mayo (stmayo)
Revision history for this message
Steven Mayo (stmayo) wrote :

Changed this as part of a larger branch to do with search highlighting. Fixes for this ticket are hopelessly intertwined with changes for https://bugs.launchpad.net/evergreen/+bug/1910440 and https://bugs.launchpad.net/evergreen/+bug/1970946 on the top two commits of this branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp1970946-Staff_Catalog_Disable_Highlight_Setting

Added a new user setting called ui.show_search_highlight. Once saved, it will replace the server-wide default - as long as the user is logged in. It can be edited by changing a new checkbox in My Account -> Preferences -> Search and History. This is the exact same setting used for disabling highlighting in the staff client, so staff can expect to always see the same behavior in both catalogs.

The button on the OPAC search results screen does NOT save this user setting. It uses URL parameters which are exactly as sticky as the old behavior, lasting until the user logs out or looks at their account info. My hope is that this caters to the use case mentioned in comment #1 of https://bugs.launchpad.net/evergreen/+bug/1910440, where staff keep their preference but can change it temporarily for screenshots.

Steps to test:
[1] Go to OPAC -> Basic Search and search for any bib
[2] Ensure that highlighting is on as that's the default behavior
[2.1] Toggle 'Enable Highlighting' on or off if you want
[3] Go to My Account -> Login to any account -> Preferences -> Search and History
[4] Note that the new checkbox 'Show search terms' should be on, which is default
[5] Uncheck 'Show search terms' and Save
[6] Search for any bib
[7] Note that highlighting should now be off, and so is the checkbox
[7.1] Toggle 'Enable Highlighting' on or off if you want
[8] Log out
[9] Search for any bib
[10] Note that highlighting will be back on again, which is the default.
EXTRA POINTS
[11] Get someone to set search.default_highlight = 0 in Open-ILS/src/templates-bootstrap/opac/parts/config.tt2 and rebuild
[12] Search the OPAC as while logged out and highlighting should be off
[13] Log in to the account you turned highlight off for and search, it will STILL be off
[14] Change the search preference back on even though the default is off and search again; it will be on

Changed in evergreen:
assignee: Steven Mayo (stmayo) → nobody
tags: added: pullrequest
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.