In case of containerized undercloud failure we may see output like: 'InstallUndercloud' object has no attribute 'heat_launch'

[Marius Cornea]

In cause of containerized undercloud failure we may see output like: 'InstallUndercloud' object has no attribute 'heat_launch'

TASK [Run openstack tripleo container image prepare] ***************************
fatal: [undercloud-0]: FAILED! => {"changed": true, "cmd": ["openstack", "tripleo", "container", "image", "prepare", "--roles-file", "/tmp/ansible.KuJFJd-role-data", "--environment-file", "/tmp/ansible.tXGIAm-prepare-param"], "delta": "0:02:52.304967", "end": "2018-07-24 14:20:41.199997", "msg": "non-zero return code", "rc": 1, "start": "2018-07-24 14:17:48.895030", "stderr": "docker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found\ndocker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found\ndocker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found\ndocker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found\ndocker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found\nCould not pull image docker-registry.engineering.redhat.com/rhosp14/openstack-ironic-neutron-agent", "stderr_lines": ["docker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found", "docker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found", "docker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found", "docker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found", "docker pull failed: Error: image rhosp14/openstack-ironic-neutron-agent:2018-07-13.3 not found", "Could not pull image docker-registry.engineering.redhat.com/rhosp14/openstack-ironic-neutron-agent"], "stdout": "", "stdout_lines": []}

NO MORE HOSTS LEFT *************************************************************

PLAY RECAP *********************************************************************
undercloud-0 : ok=151 changed=43 unreachable=0 failed=1

Install artifact is located at /home/stack/undercloud-install-20180724182041.tar.bzip2

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Deployment Failed!

ERROR: Heat log files: /var/log/heat-launcher/undercloud_deploy-mV0Sbc

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Deployment failed.
'InstallUndercloud' object has no attribute 'heat_launch'

Steps to reproduce:

[stack@undercloud-0 ~]$ cat undercloud.conf
[DEFAULT]
# Network interface on the Undercloud that will be handling the PXE
# boots and DHCP for Overcloud instances. (string value)
local_interface = eth0
local_ip = 192.168.24.1/24
undercloud_public_host = 192.168.24.2
undercloud_admin_host = 192.168.24.3
container_images_file=/home/stack/undercloud-containers.yaml
undercloud_ntp_servers=clock.redhat.com
docker_insecure_registries=docker-registry.engineering.redhat.com
undercloud_service_certificate = /etc/pki/instack-certs/undercloud.pem
[ctlplane-subnet]
local_subnet = ctlplane-subnet
cidr = 192.168.24.0/24
dhcp_start = 192.168.24.5
dhcp_end = 192.168.24.24
gateway = 192.168.24.1
inspection_iprange = 192.168.24.100,192.168.24.120
masquerade = true
#TODO(skatlapa): add param to override masq

[stack@undercloud-0 ~]$ cat undercloud-containers.yaml
# Generated with the following on 2018-07-24T14:12:08.864273
#
# openstack tripleo container image prepare default --output-env-file /home/stack/undercloud-containers.yaml --local-push-destination
#

parameter_defaults:
  ContainerImagePrepare:
  - push_destination: 192.168.24.1:8787
    set:
      ceph_image: rhceph
      ceph_namespace: brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888
      ceph_tag: 3-9
      name_prefix: openstack-
      name_suffix: ''
      namespace: docker-registry.engineering.redhat.com/rhosp14
      neutron_driver: null
      openshift_base_image: ose
      openshift_cockpit_image: registry-console
      openshift_cockpit_namespace: registry.access.redhat.com/openshift3
      openshift_cockpit_tag: v3.9
      openshift_namespace: registry.access.redhat.com/openshift3
      openshift_tag: v3.9
      tag: 2018-07-13.3

The openstack-ironic-neutron-agent image is missing the 2018-07-13.3 tag.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/587857

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/587857
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=2376fdf6fe380cfe609b5671b26f2b365dbb9b21
Submitter: Zuul
Branch: master

commit 2376fdf6fe380cfe609b5671b26f2b365dbb9b21
Author: Alex Schultz <email address hidden>
Date: Wed Aug 1 09:11:38 2018 -0600

    Drop incorrect reference to heat_launch

    I99ce8abde838f16cabefe641b107e55b508c2cf9 updated the failure message to
    not actually be a template, however the undercloud was attempting to use
    self.heat_launch when formatting the failure message. The heat_launch
    code only exists in the TripleoDeploy so this leads to a misleading
    error message during failures.

    Change-Id: Ica15fe506c06a8557d27675e450646dc96c5e6c4
    Closes-Bug: #1783389

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/589918

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/589918

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.5.0 release.