spec tests are currently broken

[Michele Baldessari]

Seen here: http://logs.openstack.org/50/585150/1/check/puppet-openstack-unit-4.8-centos-7/c803c3a/job-output.txt.gz

2018-07-24 07:08:34.681156 | centos-7 | 1) pacemaker::new::service on ubuntu-18.04-x86_64 with default parameters should compile into a catalogue without dependency cycles
2018-07-24 07:08:34.681322 | centos-7 | Failure/Error: it { is_expected.to compile.with_all_deps }
2018-07-24 07:08:34.681404 | centos-7 | RuntimeError:
2018-07-24 07:08:34.681668 | centos-7 | Could not find the daemon directory (tested [/etc/sv,/var/lib/service])
2018-07-24 07:08:34.681734 | centos-7 |
2018-07-24 07:08:34.681956 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/provider/service/runit.rb:50:in `defpath'
2018-07-24 07:08:34.682216 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type/service.rb:180:in `block (3 levels) in <module:Puppet>'
2018-07-24 07:08:34.682419 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:834:in `set_default'
2018-07-24 07:08:34.682671 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/monkey_patches.rb:87:in `call'
2018-07-24 07:08:34.682937 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/monkey_patches.rb:87:in `block in <class:Type>'
2018-07-24 07:08:34.683161 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2493:in `block in set_parameters'
2018-07-24 07:08:34.683346 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2492:in `each'
2018-07-24 07:08:34.683570 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2492:in `set_parameters'
2018-07-24 07:08:34.683774 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2389:in `initialize'
2018-07-24 07:08:34.683963 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource.rb:489:in `new'
2018-07-24 07:08:34.684156 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource.rb:489:in `to_ral'
2018-07-24 07:08:34.684400 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:632:in `block in to_catalog'
2018-07-24 07:08:34.684630 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:624:in `each'
2018-07-24 07:08:34.684852 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:624:in `to_catalog'
2018-07-24 07:08:34.685062 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:511:in `to_ral'
2018-07-24 07:08:34.685315 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/matchers/compile.rb:142:in `cycles_found?'
2018-07-24 07:08:34.685573 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/matchers/compile.rb:25:in `matches?'
2018-07-24 07:08:34.685781 | centos-7 | # ./spec/classes/pacemaker_service_spec.rb:9:in `block (5 levels) in <top (required)>'
2018-07-24 07:08:34.685819 | centos-7 |
2018-07-24 07:08:34.686074 | centos-7 | 2) pacemaker::new on ubuntu-18.04-x86_64 with default parameters should compile into a catalogue without dependency cycles
2018-07-24 07:08:34.686223 | centos-7 | Failure/Error: it { is_expected.to compile.with_all_deps }
2018-07-24 07:08:34.686290 | centos-7 | RuntimeError:
2018-07-24 07:08:34.686482 | centos-7 | Could not find the daemon directory (tested [/etc/sv,/var/lib/service])
2018-07-24 07:08:34.686537 | centos-7 |
2018-07-24 07:08:34.686737 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/provider/service/runit.rb:50:in `defpath'
2018-07-24 07:08:34.686972 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type/service.rb:180:in `block (3 levels) in <module:Puppet>'
2018-07-24 07:08:34.687149 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:834:in `set_default'
2018-07-24 07:08:34.687352 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/monkey_patches.rb:87:in `call'
2018-07-24 07:08:34.687614 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/monkey_patches.rb:87:in `block in <class:Type>'
2018-07-24 07:08:34.687820 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2493:in `block in set_parameters'
2018-07-24 07:08:34.687987 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2492:in `each'
2018-07-24 07:08:34.688171 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2492:in `set_parameters'
2018-07-24 07:08:34.688348 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2389:in `initialize'
2018-07-24 07:08:34.688535 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource.rb:489:in `new'
2018-07-24 07:08:34.688714 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource.rb:489:in `to_ral'
2018-07-24 07:08:34.688935 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:632:in `block in to_catalog'
2018-07-24 07:08:34.689123 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:624:in `each'
2018-07-24 07:08:34.689320 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:624:in `to_catalog'
2018-07-24 07:08:34.689525 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:511:in `to_ral'
2018-07-24 07:08:34.689755 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/matchers/compile.rb:142:in `cycles_found?'
2018-07-24 07:08:34.689971 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.6.14/lib/rspec-puppet/matchers/compile.rb:25:in `matches?'
2018-07-24 07:08:34.690153 | centos-7 | # ./spec/classes/pacemaker_spec.rb:9:in `block (5 levels) in <top (required)>'
2018-07-24 07:08:34.690190 | centos-7 |

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/585197

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Seems to be linked to https://github.com/rodjek/rspec-puppet/issues/629

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/585260

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michele Baldessari (<email address hidden>) on branch: master
Review: https://review.openstack.org/585197
Reason: We'll use Sofer's approach https://review.openstack.org/#/c/585260

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/585260
Committed: https://git.openstack.org/cgit/openstack/puppet-pacemaker/commit/?id=9fe625a5718e71e35dd282d6b64f4c4045263813
Submitter: Zuul
Branch: master

commit 9fe625a5718e71e35dd282d6b64f4c4045263813
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Jul 24 13:01:21 2018 +0200

    Fix rspec test on ubuntu os.

    There seems to be an issue with rspec-puppet where it doesn't have the
    necessary facts for getting the right initsystem on debian's like
    os[1]. It may then happen that it detects a runit system and
    obviously fails on service checks.

    We force that fact to systemd as this is true for all supported os.

    [1] https://github.com/rodjek/rspec-puppet/issues/629

    Change-Id: I8b406c33ae8467d54f1b8502fbde5dfd1fbb1204
    Closes-Bug: #1783302

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-pacemaker 0.7.2 release.