Symbol Library Editor bug: search filter doesn't show library name if the library is empty

Bug #1783251 reported by Gabriel Staples
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Wishlist
Jeff Young

Bug Description

Application: kicad
Version: 5.0.0-fee4fd1~65~ubuntu14.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.35.0 OpenSSL/1.0.1f zlib/1.2.8 libidn/1.28 librtmp/2.3
Platform: Linux 4.4.0-112-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.54.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.35.0
    Compiler: GCC 4.8.4 with C++ ABI 1002
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

-----------------------------------------

Symbol Library Editor bug: search filter doesn't show library name if the library is empty. It should, however, so long as the library has been added to the Global or Project library manager. When creating a new symbol library it would be nice to be able to filter it by the name you just named it so you can then immediately right-click it in the search tree and go to "import symbol", for example, to immport a symbol into it for editing.

Changed in kicad:
importance: Undecided → Wishlist
Jeff Young (jeyjey)
Changed in kicad:
milestone: none → 5.1.0
assignee: nobody → Jeff Young (jeyjey)
status: New → In Progress
Jeff Young (jeyjey)
Changed in kicad:
status: In Progress → Fix Committed
Revision history for this message
Gabriel Staples (ercaguy) wrote :

Jeff, I've got your repo on my computer (form https://code.launchpad.net/~jeyjey/kicad/+git/kicad), and did a `git pull`, but the latest commit is from 6 Jul. How do I take a look at this fix you just committed?

Revision history for this message
Jeff Young (jeyjey) wrote : Re: [Bug 1783251] Re: Symbol Library Editor bug: search filter doesn't show library name if the library is empty

@Gabriel, all my stuff is now in the main git repo on the master branch. (The private branches are only for when we’re working on stuff ahead of a pending release.)

> On 3 Aug 2018, at 17:04, Gabriel Staples <email address hidden> wrote:
>
> Jeff, I've got your repo on my computer (form
> https://code.launchpad.net/~jeyjey/kicad/+git/kicad), and did a `git
> pull`, but the latest commit is from 6 Jul. How do I take a look at this
> fix you just committed?
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1783251
>
> Title:
> Symbol Library Editor bug: search filter doesn't show library name if
> the library is empty
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> Application: kicad
> Version: 5.0.0-fee4fd1~65~ubuntu14.04.1, release build
> Libraries:
> wxWidgets 3.0.2
> libcurl/7.35.0 OpenSSL/1.0.1f zlib/1.2.8 libidn/1.28 librtmp/2.3
> Platform: Linux 4.4.0-112-generic x86_64, 64 bit, Little endian, wxGTK
> Build Info:
> wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> Boost: 1.54.0
> OpenCASCADE Community Edition: 6.8.0
> Curl: 7.35.0
> Compiler: GCC 4.8.4 with C++ ABI 1002
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=OFF
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_USE_OCC=OFF
> KICAD_SPICE=ON
>
> -----------------------------------------
>
> Symbol Library Editor bug: search filter doesn't show library name if
> the library is empty. It should, however, so long as the library has
> been added to the Global or Project library manager. When creating a
> new symbol library it would be nice to be able to filter it by the
> name you just named it so you can then immediately right-click it in
> the search tree and go to "import symbol", for example, to immport a
> symbol into it for editing.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1783251/+subscriptions

Revision history for this message
Gabriel Staples (ercaguy) wrote :

I see. I just did `git clone https://git.launchpad.net/kicad` (per here: https://code.launchpad.net/kicad). I'll search for your commit that implemented this fix.

Revision history for this message
Gabriel Staples (ercaguy) wrote :

I think I found it. `git log | grep -B 30 -A 30 -i 1783251 --color=always | less -R` reveals it as commit hash 4e3c84e733f93a251c7a3b2cd85011557b4d9d4e.

Revision history for this message
Jeff Young (jeyjey) wrote :

Yep, that's the one. Not sure why the Kicad-janitor didn't insert a link to it in this bug, although it sometimes falls asleep....

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.