mutter is ignoring wl_shell_surface_move and wl_shell_surface_resize

[Christian Rauch]

mutter (wayland) is ignoring wl_shell_surface_move and wl_shell_surface_resize request, which prevents the use of subsurfaces window decorations (example: http://github.com/christianrauch/wayland_window_decoration_example). The same example works on weston.

The fault is in the method "meta_wayland_pointer_can_grab_surface" where "pointer->focus_surface == surface" does not hold for subsurfaces. The attached patch removes the test for the focused surface and allows resizing and moving of the wl_shell surface in the example.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: mutter 3.18.3-0ubuntu2
ProcVersionSignature: Ubuntu 4.13.0-45.50~16.04.1-generic 4.13.16
Uname: Linux 4.13.0-45-generic x86_64
NonfreeKernelModules: zfs zunicode zavl zcommon znvpair nvidia_uvm nvidia_drm nvidia_modeset nvidia
ApportVersion: 2.20.1-0ubuntu2.18
Architecture: amd64
CurrentDesktop: GNOME
Date: Thu Jul 19 18:51:14 2018
InstallationDate: Installed on 2016-04-26 (813 days ago)
InstallationMedia: Ubuntu-GNOME 16.04 LTS "Xenial Xerus" - Release amd64 (20160421)
SourcePackage: mutter
UpgradeStatus: No upgrade log present (probably fresh install)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "wl_shell_fix.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Daniel van Vugt (vanvugt)]

I can't tell from the current code (which is different) if this fix is still needed. Is it?

[Christian Rauch (christianrauch)]

Well the patch is for mutter 3.18.3, so it will still be needed on this version.

However, this issue and patch are now more than 2 years old (without any response during this time). It has been fixed in newer mutter versions as used in Ubuntu 18.04 or 20.04.

[Christian Rauch (christianrauch)]

To clarify, the original issue (not being able to move subsurface) is still present on an up-to-date Ubuntu 16.04. The patch is for the original debian source package at http://archive.ubuntu.com/ubuntu/pool/universe/m/mutter/mutter_3.18.3.orig.tar.xz and is also still valid.

@vanvugt What do you mean with the code is different? The reference for the patch is still the same, but the code very likely changed between major mutter versions. I also submitted the patch to GNOME beforehand (2 years ago) but it was rejected because the "old" version 3.18 wasn't maintained anymore.

[Daniel van Vugt (vanvugt)]

I just mean the code had changed. Thanks for the update.

Since it's fixed in any Ubuntu version, the main status should be Fix Released. I don't think we care about gnome-shell in 16.04 (it actually shipped with Unity?).