Multi node deployment with ansible mech driver fails with error

[Rabi Mishra]

When doing multi-node deployments with ansible mech driver (NeutronMechanismDrivers: ansible), if OS::TripleO::Services::ComputeNeutronCorePlugin service is enabled for a role deployment fails with the below error:

        "2018-07-18 17:26:12,749 ERROR: 835448 -- Failed running docker-puppet.py for neutron",
        "2018-07-18 17:26:12,749 ERROR: 835448 -- Notice: hiera(): Cannot load backend module_data: cannot load such file -- hiera/backend/module_data_backend",
        "2018-07-18 17:26:12,750 ERROR: 835448 -- + mkdir -p /etc/puppet",
        "+ '[' -n file,file_line,concat,augeas,cron,neutron_plugin_ml2 ']'",
        "+ TAGS='--tags file,file_line,concat,augeas,cron,neutron_plugin_ml2'",
        "+ origin_of_time=/var/lib/config-data/neutron.origin_of_time",
        "+ touch /var/lib/config-data/neutron.origin_of_time",
        "+ /usr/bin/puppet apply --summarize --detailed-exitcodes --color=false --logdest syslog --logdest console --modulepath=/etc/puppet/modules:/usr/share/openstack-puppet/modules --tags file,file_line,concat,augeas,cron,neutron_plugin_ml2 /etc/config.pp",
        "ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)",
        "Warning: This method is deprecated, please use match expressions with Stdlib::Compat::Array instead. They are described at https://docs.puppet.com/puppet/latest/reference/lang_data_type.html#match-expressions. at [\"/etc/puppet/modules/neutron/manifests/init.pp\", 486]:[\"/etc/puppet/modules/tripleo/manifests/profile/base/neutron/plugins/ml2.pp\", 45]",
        " with Stdlib::Compat::Hash. There is further documentation for validate_legacy function in the README. at [\"/etc/puppet/modules/neutron/manifests/config.pp\", 136]:[\"/etc/puppet/modules/tripleo/manifests/profile/base/neutron.pp\", 141]",
        "Error: Evaluation Error: Error while evaluating a Function Call, create_resources(): second argument must be a hash at /etc/puppet/modules/neutron/manifests/plugins/ml2/networking_ansible.pp:46:3 on node reprosubnode-1.rdocloud",
        "+ rc=1",
        "+ '[' 1 -ne 2 -a 1 -ne 0 ']'",
        "+ exit 1",
        "2018-07-18 17:26:12,750 INFO: 835448 -- Finished processing puppet configs for neutron",
        "2018-07-18 17:26:12,750 ERROR: 835446 -- ERROR configuring neutron",

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/583900

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/583900
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=94f382323f3f70391e2f26baf8e43a0360fc986d
Submitter: Zuul
Branch: master

commit 94f382323f3f70391e2f26baf8e43a0360fc986d
Author: rabi <email address hidden>
Date: Thu Jul 19 12:39:25 2018 +0530

    Check for neutron_plugin_ml2_ansible service when including plugin

    We would not want ansible ml2 plugin configured for roles unless
    neutron_plugin_ml2_ansible service is enabled. Check services_names
    before including neutron puppet manifest.

    Change-Id: Ia36c62a6b7c234dd31912a8289bb1b1e4b4698fb
    Closes-Bug: #1782537

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.2.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/655679

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/655679
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=bc58f0b92e5c5fb52162c46fd4c3db8c59cacb77
Submitter: Zuul
Branch: stable/queens

commit bc58f0b92e5c5fb52162c46fd4c3db8c59cacb77
Author: rabi <email address hidden>
Date: Thu Jul 19 12:39:25 2018 +0530

    Check for neutron_plugin_ml2_ansible service when including plugin

    We would not want ansible ml2 plugin configured for roles unless
    neutron_plugin_ml2_ansible service is enabled. Check services_names
    before including neutron puppet manifest.

    Change-Id: Ia36c62a6b7c234dd31912a8289bb1b1e4b4698fb
    Closes-Bug: #1782537
    (cherry picked from commit 94f382323f3f70391e2f26baf8e43a0360fc986d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.5.0 release.