Charm does not use the provider extra binding

[David Ames]

The charm has the extra-binding provider to ensure the router id is set to an IP on the provider network. However, the template is calling the speaker_ip which is only used when in a relation with anther charm (i.e. quagga).

In testing fixes for this it was also discovered the bgp_dragent.ini file is rendered with 640 root:root perms which stops neutron from reading the file.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/583704
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-dynamic-routing/commit/?id=ba7b42e36c1d527433852e3fbb93b64248b9f9b7
Submitter: Zuul
Branch: master

commit ba7b42e36c1d527433852e3fbb93b64248b9f9b7
Author: David Ames <email address hidden>
Date: Wed Jul 18 12:04:10 2018 -0700

    Use the provider network for router id

    The router id for the dragent must be on the provider network. The
    charm was using the BGP speaker_ip which is only used for related
    test services. (i.e. quagga).

    This change guarantees the router id uses the provider extra binding
    IP.

    It also sets the group ownership to neutron for rendered config files.

    Closes-Bug: #1782433
    Partial-Bug: #1782444
    Change-Id: I4761b4c5b80a398e13e4cdf880b773df489f53b9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/584483

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/584483
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-dynamic-routing/commit/?id=50014ed7147210ec89b8a9f29e1dd7c0c70b0b1d
Submitter: Zuul
Branch: stable/18.05

commit 50014ed7147210ec89b8a9f29e1dd7c0c70b0b1d
Author: David Ames <email address hidden>
Date: Wed Jul 18 12:04:10 2018 -0700

    Use the provider network for router id

    The router id for the dragent must be on the provider network. The
    charm was using the BGP speaker_ip which is only used for related
    test services. (i.e. quagga).

    This change guarantees the router id uses the provider extra binding
    IP.

    It also sets the group ownership to neutron for rendered config files.

    cherry picked from commit ba7b42e36c1d527433852e3fbb93b64248b9f9b7

    Closes-Bug: #1782433
    Partial-Bug: #1782444
    Change-Id: I4761b4c5b80a398e13e4cdf880b773df489f53b9