MAAS

[2.5] Validation of SRV records raises incorrect exception for malformed records

Bug #1782409 reported by Kit Randel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Mike Pontillo
MAAS 2.5.0beta1

Bug Description

Attempting to add a SRV DNS record results in the exception:

'NoneType' object has no attribute 'groupdict'

Tags: track

Related branches

~mpontillo/maas:fix-srv-record-validation--bug-1782409
Alberto Donato (community): Approve
MAAS Lander: Approve
Diff: 30 lines (+5/-1)
2 files modified
src/maasserver/models/dnsdata.py (+1/-1)
src/maasserver/models/tests/test_dnsdata.py (+4/-0)
Revision history for this message
Kit Randel (blr) wrote :

Screenshot

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi Kit,

Could you please:

1. Specify the version where this issue exists?
2. Attach /var/log/maas/regiond.log ?

Thanks.

Changed in maas:
status: New → Incomplete
Kit Randel (blr)
summary: - Adding a SRV DNS record crashes
+ [2.5.x] Adding a SRV DNS record crashes
Revision history for this message
Kit Randel (blr) wrote : Re: [2.5.x] Adding a SRV DNS record crashes

Hi Andres,

This is against master, so I've indicated v2.5.x in the title, and attached the regiond log.

Andres Rodriguez (andreserl)
Changed in maas:
milestone: none → 2.5.0
importance: Undecided → Critical
status: Incomplete → Triaged
summary: - [2.5.x] Adding a SRV DNS record crashes
+ [2.5] Adding a SRV DNS record crashes
Changed in maas:
assignee: nobody → Blake Rouse (blake-rouse)
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.5.0 → 2.5.0alpha2
tags: added: track
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.5.0alpha2 → 2.5.0beta1
Andres Rodriguez (andreserl)
Changed in maas:
assignee: Blake Rouse (blake-rouse) → Mike Pontillo (mpontillo)
Revision history for this message
Mike Pontillo (mpontillo) wrote : Re: [2.5] Adding a SRV DNS record crashes

This is actually just a bug in the error message.

If you specify a SRV record with correct syntax, it works correctly. For example, I was able to add a SRV record with the following data to my test MAAS:

    0 5 5060 sipserver.maas

Changed in maas:
importance: Critical → High
Mike Pontillo (mpontillo)
summary: - [2.5] Adding a SRV DNS record crashes
+ [2.5] Validation of SRV records raises for malformed records
Mike Pontillo (mpontillo)
summary: - [2.5] Validation of SRV records raises for malformed records
+ [2.5] Validation of SRV records raises incorrect exception for malformed
+ records
MAAS Lander (maas-lander)
Changed in maas:
status: Triaged → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.